-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Niko/java doc updates #576
base: main
Are you sure you want to change the base?
Conversation
* Adding intro * Adding assignment * Adding initialization * Adding bandits
✅ Deploy Preview for eppo-data-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Niko,
Thanks for updating the docs!
I left a couple of comments and put up #599 just now for you to review and merge into your docs. Should be good to go after that.
/sdks/server-sdks/java/#assignments /sdks/server-sdks/java/assignments | ||
/sdks/server-sdks/java/#assignment-types /sdks/server-sdks/java/assignments#assignment-types | ||
/sdks/server-sdks/java/#subject-attributes /sdks/server-sdks/java/assignments#subject-attributes | ||
/sdks/server-sdks/java/#assignment-logger /sdks/server-sdks/java/assignments#assignment-logger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a redirect for the bandit-assignment-logger?
<FeatureCard | ||
title="API Reference" | ||
description="Reference for all SDK methods." | ||
link="https://github.com/Eppo-exp/java-server-sdk" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just links to the github repo. It would be awesome to have an API reference site for the SDKs.
What?
Moving the Java docs into the format similar to what we have for node.
Why?
Review instructions
Upon completion of review, this is good to merge.