-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python): Options that are None are also None in python #212
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 204ac7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for debugging and fixing this! Extra kudos for adding tests ❤️ |
Hm... it looks like the test is failing:
Did you get it passing locally? |
This should fix `null` attributes serializing to unit instead of none.
Ok, I figured it out. The bug is coming from |
@rasendubi Thanks. I was still working on figuring out some pieces of getting local builds to work so I wasn't able to test this yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find thank you! The other CI check is failing and will be fixed in the MSRV pr here (#213).
We'll get this packaged up and shipped for you early next week - cheers!
Description
Options that are
None
in rust are alsoNone
in python instead of empty tuples.Currently when it is converted back to python it ends up as tuple
()
which will create an empty tuple object instead.Testing
Updated test to include checking conversion.
References
fixes: #211