[fix] Rename cmd modules to avoid conflict with built-in cmd #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the module defined in 'codechecker_common/cmd' to 'codechecker_common/cli_commands' (as there is already a cli.py file in the same folder) in order to avoid ambiguity with Python's built-in cmd module when using `pdb.set_trace()`. The new name better reflects its purpose and eliminates potential naming conflicts. Rename all 'cmd' directories to 'cli' for consistency with 'codechecker_common/cli_commands'.
this was my original idea, to rename 'cmd' to 'commandline' but I found it grammatically incorrect, and the correct spelling 'command_line' would be maybe a bit too verbose
|
BTW I'm up for discussing what a good module name would be: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the module defined in 'codechecker_common/cmd' to 'codechecker_common/cli_commands' (as there is already a cli.py file in the same folder) in order to avoid ambiguity with Python's built-in cmd module when using
pdb.set_trace(). The new name better reflects its purpose and eliminates potential naming conflicts.Rename all 'cmd' directories to 'cli' for consistency with 'codechecker_common/cli_commands'.