Conversation
jbearer
approved these changes
Sep 17, 2025
Ayiga
reviewed
Sep 18, 2025
| server.with( | ||
| CorsMiddleware::new() | ||
| .allow_methods("GET, POST".parse::<HeaderValue>().unwrap()) | ||
| .allow_methods("GET, POST, OPTIONS".parse::<HeaderValue>().unwrap()) |
Member
There was a problem hiding this comment.
I don't believe OPTIONS needs to be included within Access-Control-Allow-Methods. After all, a pre-flight request is done using the OPTIONS verb, so you wouldn't have any way of knowing without making the initial request.
Funnily enough, GET, HEAD, and POST are always allowed anyway, but they should still be included so we do have some value here.
Here's a post that reinforces that this OPTIONS value is not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.