Fix bug in archives with uncompressed files#64
Fix bug in archives with uncompressed files#64glebdmitriew wants to merge 29 commits intoEvanOxfeld:masterfrom
Conversation
|
This is amazing @glebdmitriew and fixes the numerous reported 'Error: invalid signature' issues. Can we please get this merged upstream @EvanOxfeld? |
|
👍 This is awesome, also fixes #63. Great find @missinglink! The PR would probably need some work regarding README and package.json changes, from the looks of it. |
|
Will this get merged eventually? |
|
I would really love if this was merged. It basically saved my project! |
|
FYI to anyone using this fork of the module, you will need to change your code due to this commit which landed a few days ago glebdmitriew@10c0c29 or you will get The change is pretty simple and should look something like this: https://github.com/geopipes/geonames-stream/pull/8/files If you are currently linking to the github tarball you can test if you have this issue by executing |
|
Maybe someone should start a clean fork 😇 |
|
@glebdmitriew : can you push your version on npm as unzip2 ? Since this package looks dead it would be cool… |
|
We added the unzip2 as npm package |
|
Yes http://github.com/glebdmitriew/node-unzip-2 can resolve the problem. |
fix unzip uncompressed blank files
Use most current version of fstream dependency
npm install unzip2
issue #4 bugfix
Version bump — would you update it on npm?
Updating dependency to mitigate https://nodesecurity.io/advisories/886
Update package.json
Update package.json
This pull request fixes unzipping for uncompressed files which size is not known in the header. This fixes issues: #41, #32 and may fix #56 and #52.