Fixed issue 37, where entry.size is undefined.#92
Open
filtersweep wants to merge 1 commit intoEvanOxfeld:masterfrom
Open
Fixed issue 37, where entry.size is undefined.#92filtersweep wants to merge 1 commit intoEvanOxfeld:masterfrom
filtersweep wants to merge 1 commit intoEvanOxfeld:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a real quick first pass, with little knowledge of the rest of the codebase. The crux of the issue is that entry.size is unassigned before the "entry" event is emitted. I couldn't find anywhere where vars.uncompressedSize and vars.flags are re-assigned between the initial assignment and the usage after fileSizeKnown. So, I just moved that block up before "entry" is emitted.