You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All PR-related checks now appear addressed. The remaining failures seem to come from IO integration flakiness unrelated to this change:
integration-test-io (3.10, native)
integration-test-io (3.10, ray)
aggregate integration-tests required check
The IO logs show Hugging Face/S3 external access failures, e.g. https://huggingface.co/api/datasets/stanfordnlp/imdb/parquet returning HTTP 400 and transient S3 GET timeouts for daft-oss-public-data.
This PR only adds to_map expression construction and does not touch IO/Hugging Face/S3 code. I reran the failed checks and they still failed in the same unrelated area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time looking/working with Daft code...any process errors are strictly mine.
Changes Made
Fixes #6885
Summary
daft.functions.to_mapconstructor for key/value expression pairs.Tests
make buildDAFT_RUNNER=native pytest -q tests/expressions/test_to_map.pyDAFT_RUNNER=native pytest -q tests/expressions/test_to_list.py tests/recordbatch/struct/test_to_struct.py tests/expressions/test_to_map.pyDAFT_RUNNER=native pytest -q tests/recordbatch/test_from_py.py tests/expressions/test_to_map.pyAI usage
Used AI assistance to draft the implementation and tests; verified locally with the commands above.
Related Issues