refractor!: rename blindness effectype#317
Open
MikeSus1 wants to merge 4 commits intoExMod-Team:devfrom
Open
Conversation
replace all blinded by blurred
MikeSus1
changed the title
obvEve
approved these changes
Dec 22, 2024
skyfr0676
reviewed
Jan 14, 2025
| /// Make the player screen darker. | ||
| /// </summary> | ||
| Blinded, | ||
| Blindness, |
There was a problem hiding this comment.
and why directly rename Blinded and not make like:
/// <summary>
/// Blurs the player's screen.
/// </summary>
[Obsolete("moved to EffectType.Blindness.", true)]
Blinded
/// <summary>
/// Make the player screen darker.
/// </summary>
Blindness?
Author
There was a problem hiding this comment.
i could, ill make it so if an exiled dev tell me so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
This change only make it so the effect name match the one ingame, i got told it was on purpose to avoid a breaking change, but the old effect "blinded" is now "blurred" so it would change the effect behaviour anyways.
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other