You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't like the double parameter of player and players, cant you just stick to players and use .FirstOrDefault()? I think the change would make the methods a lot more readable imo, do you have any particular reasons for why you have both those parameters instead of one?
I don't like the double parameter of player and players, cant you just stick to players and use .FirstOrDefault()? I think the change would make the methods a lot more readable imo, do you have any particular reasons for why you have both those parameters instead of one?
@Someone-193 Then you would constantly need to create a new Ienumarable, and since these lines cannot be moved, perhaps developers might want to create new lines continuously and for short periods to update them. Wouldn't that create unnecessary garbage?
@Someone-193 Then you would constantly need to create a new Ienumarable, and since these lines cannot be moved, perhaps developers might want to create new lines continuously and for short periods to update them. Wouldn't that create unnecessary garbage?
I mean at that point they could use an ArrayPool or something, they could also re-use the same array if they're calling a draw method continuously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes






What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other