feat!: More more c#14

EXILED/Exiled.API/Extensions/MirrorExtensions.cs

@@ -56,9 +56,6 @@ public static class MirrorExtensions
         private static readonly ReadOnlyDictionary<Type, MethodInfo> ReadOnlyWriterExtensionsValue = new(WriterExtensionsValue);
         private static readonly ReadOnlyDictionary<string, ulong> ReadOnlySyncVarDirtyBitsValue = new(SyncVarDirtyBitsValue);
         private static readonly ReadOnlyDictionary<string, string> ReadOnlyRpcFullNamesValue = new(RpcFullNamesValue);
-        private static MethodInfo setDirtyBitsMethodInfoValue;
-        private static MethodInfo sendSpawnMessageMethodInfoValue;
-        private static string[] adminToyBaseSyncVarsValue;
 
         /// <summary>
         /// Gets <see cref="MethodInfo"/> corresponding to <see cref="Type"/>.
@@ -153,17 +150,17 @@ public static ReadOnlyDictionary<string, string> RpcFullNames
         /// <summary>
         /// Gets a <see cref="NetworkBehaviour.SetSyncVarDirtyBit(ulong)"/>'s <see cref="MethodInfo"/>.
         /// </summary>
-        public static MethodInfo SetDirtyBitsMethodInfo => setDirtyBitsMethodInfoValue ??= typeof(NetworkBehaviour).GetMethod(nameof(NetworkBehaviour.SetSyncVarDirtyBit));
+        public static MethodInfo SetDirtyBitsMethodInfo => field ??= typeof(NetworkBehaviour).GetMethod(nameof(NetworkBehaviour.SetSyncVarDirtyBit));
 
         /// <summary>
         /// Gets a NetworkServer.SendSpawnMessage's <see cref="MethodInfo"/>.
         /// </summary>
-        public static MethodInfo SendSpawnMessageMethodInfo => sendSpawnMessageMethodInfoValue ??= typeof(NetworkServer).GetMethod("SendSpawnMessage", BindingFlags.NonPublic | BindingFlags.Static);
+        public static MethodInfo SendSpawnMessageMethodInfo => field ??= typeof(NetworkServer).GetMethod("SendSpawnMessage", BindingFlags.NonPublic | BindingFlags.Static);
 
         /// <summary>
         /// Gets all <see cref="AdminToyBase"/> sync var names.
         /// </summary>
-        public static string[] AdminToyBaseSyncVars => adminToyBaseSyncVarsValue ??= typeof(AdminToyBase).GetProperties().Where(property => property.Name.Contains("Network")).Select(property => property.Name).ToArray();
+        public static string[] AdminToyBaseSyncVars => field ??= typeof(AdminToyBase).GetProperties().Where(property => property.Name.Contains("Network")).Select(property => property.Name).ToArray();
 
         /// <summary>
         /// Plays a beep sound that only the target <paramref name="player"/> can hear.

EXILED/Exiled.API/Features/Camera.cs

@@ -157,8 +157,6 @@ public class Camera : IWrapper<Scp079Camera>, IWorldSpace
             ["SZ CAMERA TOY"] = CameraType.SzCameraToy,
         };
 
-        private Room room;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="Camera"/> class.
         /// </summary>
@@ -220,7 +218,7 @@ internal Camera(Scp079Camera camera079)
         /// <summary>
         /// Gets the camera's <see cref="Room"/>.
         /// </summary>
-        public Room Room => room ??= Room.Get(Base.Room);
+        public Room Room => field ??= Room.Get(Base.Room);
 
         /// <summary>
         /// Gets the camera's <see cref="ZoneType"/>.

EXILED/Exiled.API/Features/Core/EActor.cs

@@ -31,8 +31,6 @@ public abstract class EActor : EObject, IEntity, IWorldSpace
 
         private readonly HashSet<EActor> componentsInChildren = HashSetPool<EActor>.Pool.Get();
         private CoroutineHandle serverTick;
-        private bool canEverTick;
-        private float fixedTickRate;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="EActor"/> class.
@@ -42,10 +40,10 @@ protected EActor()
         {
             IsEditable = true;
             CanEverTick = true;
-            fixedTickRate = DefaultFixedTickRate;
+            FixedTickRate = DefaultFixedTickRate;
             PostInitialize();
-            Timing.CallDelayed(fixedTickRate, () => OnBeginPlay());
-            Timing.CallDelayed(fixedTickRate * 2, () => serverTick = Timing.RunCoroutine(ServerTick()));
+            Timing.CallDelayed(FixedTickRate, OnBeginPlay);
+            Timing.CallDelayed(FixedTickRate * 2, () => serverTick = Timing.RunCoroutine(ServerTick()));
         }
 
         /// <summary>
@@ -99,15 +97,15 @@ public virtual Vector3 Scale
         /// </summary>
         public virtual bool CanEverTick
         {
-            get => canEverTick;
+            get;
             set
             {
                 if (!IsEditable)
                     return;
 
-                canEverTick = value;
+                field = value;
 
-                if (canEverTick)
+                if (field)
                 {
                     Timing.ResumeCoroutines(serverTick);
                     return;
@@ -122,13 +120,13 @@ public virtual bool CanEverTick
         /// </summary>
         public virtual float FixedTickRate
         {
-            get => fixedTickRate;
+            get;
             set
             {
                 if (!IsEditable)
                     return;
 
-                fixedTickRate = value;
+                field = value;
             }
         }
 

EXILED/Exiled.API/Features/Core/StateMachine/StateController.cs

@@ -19,7 +19,6 @@ namespace Exiled.API.Features.Core.StateMachine
     public abstract class StateController : EActor
     {
         private readonly List<State> states = new();
-        private State currentState;
 
         /// <summary>
         /// Gets all handled states.
@@ -31,14 +30,14 @@ public abstract class StateController : EActor
         /// </summary>
         public State CurrentState
         {
-            get => currentState;
+            get;
             set
             {
-                if (currentState.Id == value.Id)
+                if (field.Id == value.Id)
                     return;
 
-                (PreviousState = currentState).OnExit(this);
-                (currentState = value).OnEnter(this);
+                (PreviousState = field).OnExit(this);
+                (field = value).OnEnter(this);
 
                 OnStateChanged();
             }
@@ -75,7 +74,7 @@ public virtual void StateUpdate(State state)
         protected virtual void OnStateChanged()
         {
             EndStateMulticastDispatcher.InvokeAll(PreviousState);
-            BeginStateMulticastDispatcher.InvokeAll(currentState);
+            BeginStateMulticastDispatcher.InvokeAll(CurrentState);
         }
     }
 }

EXILED/Exiled.API/Features/DamageHandlers/DamageHandlerBase.cs

@@ -28,9 +28,6 @@ namespace Exiled.API.Features.DamageHandlers
     /// </summary>
     public abstract class DamageHandlerBase
     {
-        private DamageType damageType;
-        private CassieAnnouncement cassieAnnouncement;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="DamageHandlerBase"/> class.
         /// </summary>
@@ -78,8 +75,8 @@ public enum Action : byte
         /// </summary>
         public virtual CassieAnnouncement CassieDeathAnnouncement
         {
-            get => cassieAnnouncement ?? Base.CassieDeathAnnouncement;
-            protected set => cassieAnnouncement = value;
+            get => field ?? Base.CassieDeathAnnouncement;
+            protected set;
         }
 
         /// <summary>
@@ -94,19 +91,19 @@ public virtual DamageType Type
         {
             get
             {
-                if (damageType != DamageType.Unknown)
-                    return damageType;
+                if (field != DamageType.Unknown)
+                    return field;
 
-                damageType = GetDamageType();
-                return damageType;
+                field = GetDamageType();
+                return field;
             }
 
             protected set
             {
                 if (!Enum.IsDefined(typeof(DamageType), value))
                     throw new InvalidEnumArgumentException(nameof(value), (int)value, typeof(DamageType));
 
-                damageType = value;
+                field = value;
             }
         }
 

EXILED/Exiled.API/Features/Generator.cs

@@ -27,7 +27,6 @@ public class Generator : IWrapper<Scp079Generator>, IWorldSpace, IStructureSync
         /// A <see cref="List{T}"/> of <see cref="Generator"/> on the map.
         /// </summary>
         internal static readonly Dictionary<Scp079Generator, Generator> Scp079GeneratorToGenerator = new(new ComponentsEqualityComparer());
-        private Room room;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="Generator"/> class.
@@ -63,7 +62,7 @@ internal Generator(Scp079Generator scp079Generator)
         /// <summary>
         /// Gets the generator's <see cref="Room"/>.
         /// </summary>
-        public Room Room => room ??= Room.FindParentRoom(GameObject);
+        public Room Room => field ??= Room.FindParentRoom(GameObject);
 
         /// <summary>
         /// Gets or sets the generator' state.

EXILED/Exiled.API/Features/Hazards/AmnesticCloudHazard.cs

@@ -15,8 +15,6 @@ namespace Exiled.API.Features.Hazards
     /// </summary>
     public class AmnesticCloudHazard : TemporaryHazard
     {
-        private static Scp939AmnesticCloudInstance amnesticCloudPrefab;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="AmnesticCloudHazard"/> class.
         /// </summary>
@@ -36,10 +34,10 @@ public static Scp939AmnesticCloudInstance AmnesticCloudPrefab
         {
             get
             {
-                if (amnesticCloudPrefab == null)
-                    amnesticCloudPrefab = PrefabHelper.GetPrefab<Scp939AmnesticCloudInstance>(PrefabType.AmnesticCloudHazard);
+                if (field == null)
+                    field = PrefabHelper.GetPrefab<Scp939AmnesticCloudInstance>(PrefabType.AmnesticCloudHazard);
 
-                return amnesticCloudPrefab;
+                return field;
             }
         }
 

EXILED/Exiled.API/Features/Hazards/TantrumHazard.cs

@@ -18,8 +18,6 @@ namespace Exiled.API.Features.Hazards
     /// </summary>
     public class TantrumHazard : TemporaryHazard
     {
-        private static TantrumEnvironmentalHazard tantrumPrefab;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="TantrumHazard"/> class.
         /// </summary>
@@ -37,10 +35,10 @@ public static TantrumEnvironmentalHazard TantrumPrefab
         {
             get
             {
-                if (tantrumPrefab == null)
-                    tantrumPrefab = PrefabHelper.GetPrefab<TantrumEnvironmentalHazard>(PrefabType.TantrumObj);
+                if (field == null)
+                    field = PrefabHelper.GetPrefab<TantrumEnvironmentalHazard>(PrefabType.TantrumObj);
 
-                return tantrumPrefab;
+                return field;
             }
         }
 

EXILED/Exiled.API/Features/Map.cs

@@ -46,10 +46,6 @@ public static class Map
         /// </summary>
         internal static List<PocketDimensionTeleport> TeleportsValue = new();
 
-        private static AmbientSoundPlayer ambientSoundPlayer;
-
-        private static SqueakSpawner squeakSpawner;
-
         /// <summary>
         /// Gets a value indicating whether decontamination has begun in the light containment zone.
         /// </summary>
@@ -123,12 +119,12 @@ public static bool IsDecontaminationEnabled
         /// <summary>
         /// Gets the <see cref="global::AmbientSoundPlayer"/>.
         /// </summary>
-        public static AmbientSoundPlayer AmbientSoundPlayer => ambientSoundPlayer ??= ReferenceHub._hostHub.GetComponent<AmbientSoundPlayer>();
+        public static AmbientSoundPlayer AmbientSoundPlayer => field ??= ReferenceHub._hostHub.GetComponent<AmbientSoundPlayer>();
 
         /// <summary>
         /// Gets the <see cref="global::SqueakSpawner"/>.
         /// </summary>
-        public static SqueakSpawner SqueakSpawner => squeakSpawner ??= Object.FindFirstObjectByType<SqueakSpawner>();
+        public static SqueakSpawner SqueakSpawner => field ??= Object.FindFirstObjectByType<SqueakSpawner>();
 
         /// <summary>
         /// Sends a staff message to all players online with <see cref="PlayerPermissions.AdminChat"/> permission.

EXILED/Exiled.API/Features/Pickups/BodyArmorPickup.cs

@@ -27,9 +27,6 @@ namespace Exiled.API.Features.Pickups
     /// </summary>
     public class BodyArmorPickup : Pickup, IWrapper<BaseBodyArmor>
     {
-        private int helmetEfficacy;
-        private int vestEfficacy;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="BodyArmorPickup"/> class.
         /// </summary>
@@ -79,20 +76,12 @@ internal BodyArmorPickup(ItemType type)
         /// <summary>
         /// Gets or sets how strong the helmet on the armor is.
         /// </summary>
-        public int HelmetEfficacy
-        {
-            get => helmetEfficacy;
-            set => helmetEfficacy = value;
-        }
+        public int HelmetEfficacy { get; set; }
 
         /// <summary>
         /// Gets or sets how strong the vest on the armor is.
         /// </summary>
-        public int VestEfficacy
-        {
-            get => vestEfficacy;
-            set => vestEfficacy = value;
-        }
+        public int VestEfficacy { get; set; }
 
         /// <summary>
         /// Gets or sets how much faster stamina will drain when wearing this armor.
@@ -131,8 +120,8 @@ internal override void ReadItemInfo(Item item)
             base.ReadItemInfo(item);
             if (item is Armor armoritem)
             {
-                helmetEfficacy = armoritem.HelmetEfficacy;
-                vestEfficacy = armoritem.VestEfficacy;
+                HelmetEfficacy = armoritem.HelmetEfficacy;
+                VestEfficacy = armoritem.VestEfficacy;
                 StaminaUseMultiplier = armoritem.StaminaUseMultiplier;
                 StaminaRegenMultiplier = armoritem.StaminaRegenMultiplier;
                 AmmoLimits = armoritem.AmmoLimits;
@@ -146,8 +135,8 @@ protected override void InitializeProperties(ItemBase itemBase)
             base.InitializeProperties(itemBase);
             if (itemBase is BodyArmor armoritem)
             {
-                helmetEfficacy = armoritem.HelmetEfficacy;
-                vestEfficacy = armoritem.VestEfficacy;
+                HelmetEfficacy = armoritem.HelmetEfficacy;
+                VestEfficacy = armoritem.VestEfficacy;
                 StaminaUseMultiplier = armoritem._staminaUseMultiplier;
                 StaminaRegenMultiplier = armoritem.StaminaRegenMultiplier;
                 AmmoLimits = armoritem.AmmoLimits.Select(limit => (ArmorAmmoLimit)limit);