[No QA] Scope HelpDot docs review to PR opened/ready_for_review only#92162
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Scope HelpDot docs review to PR opened/ready_for_review only#92162MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
The /review-helpdot-pr step previously also re-ran on every Contributor+ approval (pull_request_review: submitted), producing repeated full QA review rounds on help-site PRs. Gate the docs step to pull_request_target events so it runs once at submission. Code review behavior is unchanged. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The HelpDot QA review (
/review-helpdot-pr, the docs step in the "PR Reviews with Claude Code" workflow) previously ran on bothpull_request_target(PRopened/ready_for_review) andpull_request_review: submitted— meaning it re-ran in full every time a Contributor+ approved the PR. Each run re-reviews all changed docs files from scratch with no deduplication, so help-site PRs that went through multiple approval cycles accumulated several rounds of bot review comments (e.g. #90535 got a fresh round after each approval).This change adds
&& github.event_name == 'pull_request_target'to the "Run Claude Code (docs)" step'sifcondition so the docs review only runs once at submission (opened/ready_for_review). The code-review step (src/**) is intentionally left unchanged and still re-runs on Contributor+ approval.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/643291
PROPOSAL: https://github.com/Expensify/Expensify/issues/643291#issuecomment-4589848893
Tests
CI-only workflow change — no app runtime behavior is affected. Validation performed:
ifcondition of the "Run Claude Code (docs)" step.github.event_name == 'pull_request_target'is already used as a valid expression elsewhere in the same workflow (lines 47 and 51).Offline tests
N/A — CI workflow change.
QA Steps
[No QA]— this is a CI/workflow configuration change with no user-facing impact.PR Author Checklist
### Fixed Issuessection abovemainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — CI workflow change, no UI impact.