fix(cook): bind retry ownership at reservation - #13565
Merged
Merged
Conversation
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13368.
Stacked on #13558 so one candidate can validate both prerequisite runtime repairs before retrying #11858. The focused diff remains the reservation ownership fix below.
Root cause
A local Cook retry published its bounded
local_cook_supervisorlease before controller admission, but did not publish thecook_idrequired byhas_live_pending_local_cook_supervisor. While admission waited, daemon reconciliation classified the first visible successor as ownerless and cancelled it asmissing_runner_pid; recipe binding added the Cook identity only after cancellation had already won.Change
Verification
cargo test -p homeboy-agents --lib agent_task_service::execution::tests(7 passed)cargo test -p homeboy-agents --lib agent_task_service::discovery::tests(1 passed)cargo test -p homeboy-agents --lib retryable_pre_provider_retry_concurrently_claims_one_successor(2 passed, including cross-process coverage)cargo test -p homeboy-lab-runner --lib execution::daemon::admission_tests(8 passed)cargo fmt --all -- --checkgit diff --checkAI Assistance
OpenAI GPT-5.6 Sol via OpenCode inspected the durable failed-run record, traced the reservation and reconciliation boundaries, implemented the atomic metadata fix and regression coverage, and ran the focused verification. Chris Huber directed the work and remains responsible.