Linux: Moves DRM LRU FD cache to be per-thread #5211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
approved these changes
Jan 10, 2026
neobrain
reviewed
Jan 12, 2026
Sonicadvance1
force-pushed
the
46
branch
3 times, most recently
from
e831d04 to
ab80d87
Compare
neobrain
reviewed
Jan 19, 2026
Member
neobrain
left a comment
neobrain
left a comment
There was a problem hiding this comment.
Getting there. To reiterate, implementation details should stay in the cpp file.
This was a nasty race condition where each thread could be accessing the DRM cache at any given moment. Move it over to a per thread object that is only allocated once it gets used. Also removes an `atexit` registration that contributes to crashing on exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a nasty race condition where each thread could be accessing the DRM cache at any given moment. Move it over to a per thread object that is only allocated once it gets used.
Also removes an
atexitregistration that contributes to crashing on exit.