Skip to content

Conversation

@kingbuzzman
Copy link
Contributor

Fixes #922

  • Issue with mongoengine throwing a DeprecationWarning

@francoisfreitag
Copy link
Member

Thanks! It looks like the tests are now passing. 🎉

Do you have an understanding of the cause of that deprecation warning? Is there a change to make in factory_boy to better use mongoengine and avoid this warning?

@kingbuzzman
Copy link
Contributor Author

kingbuzzman commented May 6, 2022

I honestly don't know and have very little knowledge of mongo. I have a big PR that I hope you will accept [hint][wink][hint] soon, and this was a blocker. I didn't look into it further than just getting the tests to go green.

@francoisfreitag
Copy link
Member

Nice, we came to the same conclusion. #924

@kingbuzzman
Copy link
Contributor Author

LOL, great minds think alike ;)

@kingbuzzman
Copy link
Contributor Author

PS. i used single quotes because the rest of the code uses single quotes in that file.

@francoisfreitag
Copy link
Member

Too used to Black I guess. It’s been on the table for a while #843.

@kingbuzzman
Copy link
Contributor Author

kingbuzzman commented May 6, 2022

Are you merging #924 then? Do I close this one?

@francoisfreitag
Copy link
Member

Yes, please. I marked you as a co-author for #924.

@kingbuzzman kingbuzzman closed this May 6, 2022
@kingbuzzman kingbuzzman deleted the bugfix/fix-tests branch May 6, 2022 08:59
@kingbuzzman kingbuzzman restored the bugfix/fix-tests branch May 6, 2022 08:59
@kingbuzzman kingbuzzman deleted the bugfix/fix-tests branch May 6, 2022 08:59
@kingbuzzman
Copy link
Contributor Author

Ugh, stupid button :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests are broken

2 participants