Skip to content

Add codecov #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −2
Open

Add codecov #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71b94fc
add codecov:
gkorland Jan 14, 2025
f03c866
Merge branch 'main' into codecov
gkorland Feb 24, 2025
9088bc9
Update .wordlist.txt
gkorland Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,11 @@ jobs:
REGION: ${{ vars.REGION }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
run: poetry run pytest
run: poetry run pytest --cov-branch --cov-report=xml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add source specification to pytest-cov command.

The coverage command should specify which package to measure. Without it, coverage might miss some files or include unnecessary ones.

-poetry run pytest --cov-branch --cov-report=xml
+poetry run pytest --cov=graphrag_sdk --cov-branch --cov-report=xml
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: poetry run pytest --cov-branch --cov-report=xml
run: poetry run pytest --cov=graphrag_sdk --cov-branch --cov-report=xml


- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true

3 changes: 2 additions & 1 deletion .wordlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,5 @@ APIs
Embeddings
NLP
graphrag
gemini
gemini
codecov
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# GraphRAG
[![Dockerhub](https://img.shields.io/docker/pulls/falkordb/falkordb?label=Docker)](https://hub.docker.com/r/falkordb/falkordb/)
[![pypi](https://badge.fury.io/py/graphrag_sdk.svg)](https://pypi.org/project/graphrag_sdk/)
[![codecov](https://codecov.io/gh/falkordb/graphrag-sdk/graph/badge.svg?token=UKXzlNBark)](https://codecov.io/gh/falkordb/graphrag-sdk)
[![Discord](https://img.shields.io/discord/1146782921294884966?style=flat-square)](https://discord.gg/6M4QwDXn2w)
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.1-4baaaa.svg)](CODE_OF_CONDUCT.md)

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ litellm = ["litellm", "ollama"]

[tool.poetry.group.test.dependencies]
pytest = "^8.2.1"
pytest-cov = "^6.0.0"

[tool.poetry.group.dev.dependencies]
sphinx = "^7.3.7"
Expand Down
Loading