S3 compatibility issues #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jimp100 wants to merge 2 commits into FantasticFiasco:master from jimp100:master

jimp100 commented Oct 14, 2025 •

edited

Loading

This fixes a couple if issues using library with S3 API.

Removed the test for POST requests when using S3. POST is a legitimate request for S3 when Creating or Completing a Multipart Upload. Possibly some other methods too.
Reference AWS Docs:

Added support for Flag Parameters in querystring. These are parameters without a value: i.e. http://.../?uplaods
This is the required request format when creating a Multipart Uplaod.
Reference AWS Docs:

API_CreateMultipartUpload_RequestSyntax

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works

jimp100 added 2 commits

October 14, 2025 09:09


          Removed S3 POST not supported check

1bcafd2

S3 API requires POST requests for CreateMultipartUpload and CompleteMultipartUpload.  There may be others.

Ref:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateMultipartUpload.html#API_CreateMultipartUpload_RequestSyntax
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html#API_CompleteMultipartUpload_RequestSyntax


          Update CanonicalRequest.cs - Supports flag parameters in querystring

2da3686

Supports flag parameters in query string.  These are parameters with no values.  E.g. http://.../?uploads
This is the format of the POST request needed to create a multipart upload in S3
Ref: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateMultipartUpload.html#API_CreateMultipartUpload_RequestSyntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet