Skip to content

[OoT] Raise error on degenerate triangles #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yanis002 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[OoT] Raise error on degenerate triangles #636

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
444c0df
skip and warn on degen wall tris
Yanis002 Dec 2, 2025
4c81191
error instead of warn
Yanis002 Dec 2, 2025
9dc454c
Merge remote-tracking branch 'upstream/main' into fix-degen
Yanis002 Feb 25, 2026
d74757a
review
Yanis002 Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions fast64_internal/z64/exporter/collision/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ def getCollisionData(dataHolder: Optional[Object], transform: Matrix, useMacros:
for i, face in enumerate(meshObj.data.loop_triangles):
material = meshObj.material_slots[face.material_index].material
colProp = material.ootCollisionProperty
raise_error = False

# get bounds and vertices data
planePoint = transform @ meshObj.data.vertices[face.vertices[0]].co
Expand All @@ -128,13 +129,26 @@ def getCollisionData(dataHolder: Optional[Object], transform: Matrix, useMacros:
)
distance = convertIntTo2sComplement(distance, 2, True)

def sq(val):
return val * val

nx = (y2 - y1) * (z3 - z2) - (z2 - z1) * (y3 - y2)
ny = (z2 - z1) * (x3 - x2) - (x2 - x1) * (z3 - z2)
nz = (x2 - x1) * (y3 - y2) - (y2 - y1) * (x3 - x2)
magSqr = nx * nx + ny * ny + nz * nz
magSqr = sq(nx) + sq(ny) + sq(nz)
if magSqr <= 0:
print("INFO: Ignore denormalized triangle.")
continue
raise_error = True

# for walls only, see https://github.com/zeldaret/oot/blob/eb5dac74d6435baf85ced9158d3ff915ba8872ca/src/code/z_bgcheck.c#L751
if normal[1] >= -0.8 and normal[1] <= 0.5:
normal_xz = math.sqrt(sq(normal[0]) + sq(normal[2]))
if math.fabs(normal_xz) < 0.008:
Copy link
Contributor

@Dragorn421 Dragorn421 Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you use math but it's not imported

raise_error = True

if raise_error:
raise PluginError(
f"degenerate triangle detected on mesh object '{meshObj.name}' (material name is '{material.name}')"
)

indices: list[int] = []
for pos in [(x1, y1, z1), (x2, y2, z2), (x3, y3, z3)]:
Expand Down