-
-
Notifications
You must be signed in to change notification settings - Fork 811
Fix #1114: make BufferRecyclerPool generic #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -262,7 +262,7 @@ public static int collectDefaults() { | |||
/** | |||
* @since 2.16 | |||
*/ | |||
protected BufferRecyclerPool _bufferRecyclerPool; | |||
protected BufferRecyclerPool<BufferRecycler> _bufferRecyclerPool; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will probably consider renaming of BufferRecyclerPool
as it'll allow recycling other things, but initially leaving name as-is to simplify merging to master
.
* | ||
* @since 2.16 | ||
*/ | ||
public final class JsonBufferRecyclerPools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will move BufferRecycler
-bound implementations here next.
@cowtowncoder I saw what you did and I agree with this change.I also originally implemented the pool in a generic way because I "felt" it was the right thing to do, but then I reverted it. I also checked that this works fine with the quarkus integration that I'm attempting. By the way we would need the stable 2.16 asap in order to start using the pool also on our side, do you have any on when it will be released? |
@mariofusco I have been about to send an email about 2.16 plans. Things are quite close to getting RC1 out; I just have one feature I really want to get in Also: I (or someone else) need to work on using now-generic pools to replace existing |
Making good progress on "last" issue to resolve (databind , then FasterXML/jackson-databind#4096); email sent. |
PR to implement #1114 by rewriting
BufferRecyclerPool
, implementations so that there are:BufferRecycler
)BufferRecycler
values.Will add new container class
JsonBufferRecyclers
for latter, keepBufferRecyclerPool
for former.Will not yet rename
BufferRecyclerPool
but may consider it as follow up.