-
-
Notifications
You must be signed in to change notification settings - Fork 811
Add StreamReadCapability.EXACT_FLOATS
to indicate whether parser can expose exact floating-point values or not
#733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8c74f6f
Add failing test for JSON roundtrip precision loss
htmldoug 33a4c64
Add StreamReadCapabililty.EXACT_FLOATS & fix copyCurrentEvent precisi…
htmldoug 1cb5dfb
Add failing copyCurrentEvent test.
htmldoug aaa3223
Fix copyCurrentEvent test.
htmldoug e1d9c07
Descope. Remove failing tests.
htmldoug 3c77b49
Move test to /failing
htmldoug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
src/test/java/com/fasterxml/jackson/failing/ParserPrecisionLoss733Test.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
package com.fasterxml.jackson.failing; | ||
|
||
import com.fasterxml.jackson.core.BaseTest; | ||
import com.fasterxml.jackson.core.JsonFactory; | ||
import com.fasterxml.jackson.core.JsonGenerator; | ||
import com.fasterxml.jackson.core.JsonParser; | ||
|
||
import java.io.ByteArrayOutputStream; | ||
import java.io.StringWriter; | ||
|
||
public class ParserPrecisionLoss733Test extends BaseTest { | ||
final JsonFactory JSON_F = newStreamFactory(); | ||
|
||
/** | ||
* Attempt to pass a BigDecimal value through without losing precision, | ||
* e.g. for pretty printing a file. | ||
*/ | ||
public void testCopyCurrentEventBigDecimal() throws Exception { | ||
String input = "1e999"; | ||
JsonParser parser = JSON_F.createParser(input); | ||
parser.nextToken(); | ||
StringWriter stringWriter = new StringWriter(); | ||
JsonGenerator generator = JSON_F.createGenerator(stringWriter); | ||
generator.copyCurrentEvent(parser); | ||
parser.close(); | ||
generator.close(); | ||
String actual = stringWriter.toString(); | ||
assertEquals(input, actual); | ||
} | ||
|
||
/** | ||
* Same as {@link #testCopyCurrentEventBigDecimal()} using copyCurrentStructure instead. | ||
*/ | ||
public void testCopyCurrentStructureBigDecimal() throws Exception { | ||
String input = "[1e999]"; | ||
JsonParser parser = JSON_F.createParser(input); | ||
parser.nextToken(); | ||
StringWriter stringWriter = new StringWriter(); | ||
JsonGenerator generator = JSON_F.createGenerator(stringWriter); | ||
generator.copyCurrentStructure(parser); | ||
parser.close(); | ||
generator.close(); | ||
String actual = stringWriter.toString(); | ||
assertEquals(input, actual); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.