improve performance with parsing bigints with lots of digits #826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing numbers in Java has poor performance characteristics. Parse time increases exponentially as the number of digits increases.
Using BigDecimalParser to parse BigIntegers has better performance when there are a lot of digits. It is slower for more usual numbers. From benchmarking, BigDecimalParser is more performant when you have approx 1250 digits and as you head to 10k, 100k digits, it is much faster. BigDecimalParser is not O(n) but it is better than
new BigInteger(string)
.Relates to #814