Skip to content

Fix #3053 (Serialize enums to lowercase) #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix #3053 (Serialize enums to lowercase) #3054

wants to merge 1 commit into from

Conversation

vojkny
Copy link

@vojkny vojkny commented Feb 12, 2021

No description provided.

@cowtowncoder
Copy link
Member

Apologies for letting this one fall through the cracks: I think it's a good PR.

I am +1 for adding configurability, but not through existing SerializationFeature, only because its capacity is limited and the idea is to keep that for more general settings. Up until now, however, there hasn't been any good alternative.
But Jackson 2.14 will finally implement this:

https://github.com/FasterXML/jackson-future-ideas/wiki/JSTEP-7

and I will try to collect ideas for EnumFeature options: this one sounds like a very good candidate.
To support this, there's some work to be done, similar to how #3421 added JsonNodeFeature: @knyttl if you are still interested, I could help make this happen. Or if you don't have time I can maybe implement this on my own when I get some more time.

@vojkny
Copy link
Author

vojkny commented May 3, 2022

I am afraid I am not entirely sure about the way this should be implemented so if you want to implement it differently I guess, you better do it yourself 🙏

@cowtowncoder cowtowncoder added the enum Related to handling of Enum values label Aug 3, 2022
@JooHyukKim
Copy link
Member

I recently worked on EnumSerialization a little bit. ✌️
I will try to make a PR if I have time

@cowtowncoder
Copy link
Member

I recently worked on EnumSerialization a little bit. ✌️ I will try to make a PR if I have time

Yes, that'd be great! I didn't have time to do this but think it would be quite doable.

@JooHyukKim
Copy link
Member

I recently worked on EnumSerialization a little bit. ✌️ I will try to make a PR if I have time

Yes, that'd be great! I didn't have time to do this but think it would be quite doable.

For sure! done in #3776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enum Related to handling of Enum values
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants