Fix #5398: ignore + rename #5410
Conversation
cowtowncoder
added
the
gen-ai
| Test5398 result = MAPPER.readValue(json, Test5398.class); | ||
| assertNotNull(result); | ||
| // Since setter is ignored, the deserialized object should have the default value | ||
| assertEquals("someValue", result.getProp()); |
There was a problem hiding this comment.
@cowtowncoder just a nitpick but here I think the test is too ambiguous, it would have been better to set original's prop to a different value than the default one, to validate that it's indeed the default value that is used and not the one coming from json.
I can submit a PR if you want :)
There was a problem hiding this comment.
Ha! I tried and actually the comment
// Since setter is ignored, the deserialized object should have the default value
Is incorrect, if I remove the default value from the class and set it manually just before calling writeValueAsString, then result.getProp() has the value "someValue".
I tested on 2.17 too and it was like that also.
There was a problem hiding this comment.
And this behaviour is actually consistent with when we don't rename the prop (cf my examples in #5398 (comment)). I proposed an improvement of this test here: #5412
Fixes #5398