Fixes wrapping of IonException with StreamReadException #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lol. Yes, definitely my bad. Thank you for pointing out the obvious problem & providing the fix. A bit embarrassing since I have done conversions earlier and forgot this obvious difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrapping of
IonExceptionwithStreamReadException.When this patch was merged from
2.14tomasterfor #311, the calls towrapError(...)were replaced with calls to_constructReadException(...).However, the behavior of these two methods is not the same—
_wrapError(...)throws the new exception whereas_constructReadException(...)returns the new exception.This PR adds the necessary
throws in front of the calls to_constructReadException(...)inIonParser.