Skip to content

Added a new feature to disable wrapping of identifiers during proxy serialization #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2020

Conversation

jobosk
Copy link
Contributor

@jobosk jobosk commented Jul 1, 2020

Following issue #136, this PR is intended to add a new backswards-compatible feature, that allows serialization of lazy loaded objects as identifiers in numeric values, rather than wrapped in objects. The new Feature "WRAP_IDENTIFIER_IN_OBJECT" (i.e. current behaviour) is enabled by default (to avoid double negative), and can be disabled if desired.

@jobosk jobosk closed this Jul 1, 2020
@jobosk jobosk reopened this Jul 3, 2020
@cowtowncoder
Copy link
Member

I think PR looks good so the only thing I need is the Contributor License
Agreement (CLA) from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and I can merge this to be included in 2.12!

@jobosk
Copy link
Contributor Author

jobosk commented Jul 9, 2020

I have just commited the Javadoc annotation.
Due to the COVID situation I'm somewhere where I dont have access to a printer all that easily, but I haven't forgot and I will send it ASAP

@cowtowncoder
Copy link
Member

@jobosk No problem at all, and sorry about the hassle with CLA. My main concern is just that I don't forget to follow up on this, so whenever you can do that. There may be another way to convert CLA pdf to image file, then add text on other fields but scan signature (like write it on paper, take a photo, paste that on CLA image). I think some contributors have done that -- I wish I had better steps to suggest.

@cowtowncoder cowtowncoder merged commit cacdb5b into FasterXML:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants