Ignore generated methods for default arguments#603
Merged
pjfanning merged 1 commit intoFasterXML:2.14from Sep 9, 2022
Merged
Conversation
Contributor
Author
|
This was discovered from this Stack Overflow question https://stackoverflow.com/q/73655638/29470 |
TimMoore
commented
Sep 9, 2022
| val name = m.getName | ||
| //special cases to prevent shadow fields associated with lazy vals being serialized | ||
| name == "0bitmap$1" || name.endsWith("$lzy1") || super.hasIgnoreMarker(m) | ||
| name == "0bitmap$1" || name.endsWith("$lzy1") || name.contains("$default$") || super.hasIgnoreMarker(m) |
Contributor
Author
There was a problem hiding this comment.
I don't know if this is really the best way to filter these methods out, but it's the best way I could find.
Based on the spec at https://docs.scala-lang.org/sips/named-and-default-arguments.html#default-arguments-1
Member
There was a problem hiding this comment.
thanks - probably the best way to go
Contributor
Author
|
I wrote this test-first. Here are the failures that result without the change to |
pjfanning
pushed a commit
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Tim Moore <tim.moore@lightbend.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a method with default arguments has a name that matches JavaBeans property conventions, the generated method that computes the default argument expression is detected as a property.