Prevent deserialization of "" as null for Duration, Instant, LocalTime, OffsetTime, Period, ZoneDateTime, ZoneId, ZoneOffset and YearMonth in "strict" (non-lenient)
#144
+775
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso added tests for empty string handling for Duration, Instant and ZonedDateTime deserializers.
|
This is ready for review, though still need to add fix to |
kupci
changed the title
null for Duration, Instant, LocalTime, OffsetTime, and YearMonth in "strict" (non-lenient) null for Duration, Instant, LocalTime, OffsetTime, Period, ZoneDateTime, ZoneId, ZoneOffset and YearMonth in "strict" (non-lenient)
kupci
commented
Oct 18, 2019
| import java.time.ZoneId; | ||
| import java.time.ZoneOffset; | ||
| import java.time.ZonedDateTime; | ||
| import java.time.*; |
There was a problem hiding this comment.
IntelliJ is helpfully removing all the imports and starring them, I'll need to find that setting and fix this...
kupci
commented
Oct 18, 2019
| import java.time.OffsetDateTime; | ||
| import java.time.ZoneId; | ||
| import java.time.ZoneOffset; | ||
| import java.time.*; |
kupci
commented
Oct 18, 2019
| import com.fasterxml.jackson.datatype.jsr310.MockObjectConfiguration; | ||
| import com.fasterxml.jackson.datatype.jsr310.ModuleTestBase; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import static org.junit.Assert.*; |
|
LGTM (quick glance, but based on previous work, scope, I don't see high risk). Makes sense for 2.11 in particular, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the java.time classes Duration, Instant, LocalTime, OffsetDateTime, OffsetTime, Period, ZoneDateTime, ZoneId, ZoneOffset and YearMonth, this fix prevents an empty string from being mapped to null where the "strict" (non-lenient) configuration is set.
See issue #138