Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPPSF-6057 category for enriched-content-read-api #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsvetko24
Copy link
Contributor

@tsvetko24 tsvetko24 commented Mar 5, 2025

Description

  • Service enriched-content-read-api adopts the new Go impl. of document-store-api-go.
  • This change is adoption in categories, where the enriched-content-read-api service is involved.

What

Add document-store-api-go or replace document-store-api with document-store-api-go in categories where enriched-content-read-api is listed.

Why

UPPSF-6057

Anything, in particular, you'd like to highlight to reviewers

Mention here sections of code which you would like reviewers to pay extra attention to. E.g.

Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide

 * Service enriched-content-read-api adopts the new Go impl. of document-store-api-go.
 * This change is adoption in categories, where the enriched-content-read-api service is involved.
@tsvetko24 tsvetko24 requested a review from a team as a code owner March 5, 2025 11:40
Copy link

Coverage Status

coverage: 65.312%. remained the same
when pulling bdcf9a7 on feature/UPPSF-6057
into b4f5214 on master.

@tsvetko24 tsvetko24 requested a review from a team March 5, 2025 14:12
Copy link
Contributor

@lokendersinghft lokendersinghft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: We are adding this service to more categories than its predecessor document-store-api, which makes sense since the other services in those categories are dependent on document-store.

I assume we will add it to content-read and image-publish when we update the content-public-read and content-ingester respectively.

@tsvetko24 tsvetko24 requested a review from a team March 6, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants