Skip to content

[cmake] Try to make it work again #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

raedrizqie
Copy link

No description provided.

@raedrizqie
Copy link
Author

seems like nobody is interested with this.. closing..

@raedrizqie raedrizqie closed this Jul 31, 2024
@raedrizqie raedrizqie deleted the cmake-update branch July 31, 2024 10:47
@mariuz
Copy link
Member

mariuz commented Aug 1, 2024

@raedrizqie please reopen i will test it :)

Copy link
Member

@mariuz mariuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok at first view

Copy link
Member

@mariuz mariuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes

@raedrizqie
Copy link
Author

i will reopen it

@aafemt
Copy link
Contributor

aafemt commented Aug 1, 2024

Don't be too nervous. Firebird core team guys work on their own tasks. There is nobody to review and accept pull requests. But still from time to time they are reviewed. Just let it hang here for a year or two.

@raedrizqie
Copy link
Author

I had recreated the cmake branch.. is there any way i can reopen using this same PR, or should i open a new PR?

@AlexPeshkoff
Copy link
Member

Create a new one - will take a look at it.

@raedrizqie
Copy link
Author

The new PR is here: #8201 . thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants