Skip to content

Fix conversion warnings in CvtFormat#8642

Merged
mrotteveel merged 2 commits into
FirebirdSQL:masterfrom
mrotteveel:cvt-format-warnings
Jul 9, 2025
Merged

Fix conversion warnings in CvtFormat#8642
mrotteveel merged 2 commits into
FirebirdSQL:masterfrom
mrotteveel:cvt-format-warnings

Conversation

@mrotteveel
Copy link
Copy Markdown
Member

@mrotteveel mrotteveel commented Jul 8, 2025

  • adds some convenience methods for std::string_view in StatusVector and string

@mrotteveel
Fix conversion warnings in CvtFormat
184ca30 
+ adds some convenience methods for std::string_view
@mrotteveel mrotteveel self-assigned this Jul 8, 2025
@mrotteveel mrotteveel requested a review from asfernandes July 8, 2025 13:19
@mrotteveel
Copy link
Copy Markdown
Member Author

mrotteveel commented Jul 8, 2025 •
edited
Loading

@asfernandes My reason for using a PR are:

  1. is it OK to add these methods accepting std::string_view?
  2. Should I add more complete support instead of just those two methods I needed to solve my immediate problem?

asfernandes
asfernandes reviewed Jul 9, 2025
View reviewed changes
Comment thread src/common/StatusArg.h Outdated
Comment thread src/common/classes/fb_string.h Outdated
@mrotteveel
Copy link
Copy Markdown
Member Author

mrotteveel commented Jul 9, 2025

Also replaced a use of const string_view& I did earlier.

@mrotteveel mrotteveel merged commit ad8dd70 into FirebirdSQL:master Jul 9, 2025
23 checks passed
@mrotteveel mrotteveel deleted the cvt-format-warnings branch July 9, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asfernandes asfernandes asfernandes approved these changes

Assignees

@mrotteveel mrotteveel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrotteveel @asfernandes