Fix upgrade-pkhex workflow (issue #16) - #17
Open
jackgopack4 wants to merge 4 commits into
Open
Conversation
- Bump .NET SDK from 9.0.x to 10.0.x (PKHeX.Core now targets net10.0) - Update hardcoded net9.0 paths to net10.0 in copy and xcopy steps - Fix wrong GpssConsole.csproj path (missing GpssConsole/ subdirectory) - Use dynamic default branch for git push instead of hardcoded master Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace EntityContext.Generation() with PKM.Format (C# 14 extension member syntax not accessible from GpssConsole) - Replace DecryptedBoxData/DecryptedPartyData with WriteDecryptedDataStored/ WriteDecryptedDataParty Span-based API - Update bundled DLLs to latest PKHeX.Core and PKHeX.Core.AutoMod (net10.0) Closes FlagBrew#18. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks. Added to my review todo-list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16. Closes #18.
Changes
Workflow fixes (
upgrade-pkhex.yml).NET SDKfrom9.0.xto10.0.x— PKHeX.Core now targetsnet10.0net9.0paths tonet10.0in the NuGet cache copy andxcopystepsGpssConsole.csprojpath — file is atGpssConsole/GpssConsole.csproj, not workspace rootgit push origin masterwith${{ github.event.repository.default_branch }}GpssConsole API compatibility (
GpssConsole/utils/PKhex.cs,GpssConsole/models/Legality.cs)pokemon.Context.Generation()withpokemon.Format— PKHeX movedGenerationto a C# 14 extension member which GpssConsole cannot callPKM.DecryptedBoxData/PKM.DecryptedPartyData(removed) with the newWriteDecryptedDataStored/WriteDecryptedDataPartySpan-based APIUpdated DLLs (
GpssConsole/deps/)PKHeX.Core.dllandPKHeX.Core.AutoMod.dllto latestnet10.0buildsVerification
Full end-to-end workflow run on fork (all steps ✓ including
Commit and Push DLLs):https://github.com/jackgopack4/local-gpss/actions/runs/25404743165