Skip to content

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Aug 12, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Migrates identity page feature row to a typescript component. This allows us to:

  • Get further reuse from feature row components
  • Standardise the way we show features
  • Makes the work to show feature deltas for a segment a lot more straight forward

How did you test this code?

  • Test MV, segment and user overrides
  • E2E cover a lot of this

Note

Extracts a reusable feature override row (with CTA and override descriptions), replaces inline logic on UserPage, and adds supporting utils plus minor type/query/permission tweaks.

  • UI/Identity:
    • Extracts reusable components for feature overrides: FeatureOverrideRow, FeatureOverrideCTA, IdentityOverrideDescription, MultivariateOverrideDescription, SegmentOverrideDescription.
    • Refactors UserPage to use FeatureOverrideRow; removes duplicated toggle/value/override logic and related inline UI.
  • Utils:
    • Adds common/featureValuesEqual for comparing flag values.
    • Adds Utils.getOverridePermission helper and integrates with useHasPermission.
  • Types/Queries:
    • Broadens projectId types to string | number in multiple components (IdentityTraits, CreateSegment loader, TableTagFilter).
    • Updates RTK query calls to use skip and string coercion where needed.
  • Filters:
    • TableGroupsFilter drops projectId prop.
    • TableTagFilter supports flexible projectId and conditional tag fetching.

Written by Cursor Bugbot for commit 3ee508e. This will update automatically on new commits. Configure here.

@kyle-ssg kyle-ssg requested review from a team as code owners August 12, 2025 13:00
@kyle-ssg kyle-ssg requested review from Zaimwa9 and tiagoapolo and removed request for a team August 12, 2025 13:00
@vercel
Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 18, 2025 10:36am
flagsmith-frontend-preview Ready Ready Preview Comment Nov 18, 2025 10:36am
flagsmith-frontend-staging Ready Ready Preview Comment Nov 18, 2025 10:36am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5920 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5920 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5920 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5920 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5920 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5920 Finished ✅ Results

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (94bea60) to head (df8de68).
⚠️ Report is 520 commits behind head on feat/segment-change-requests.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feat/segment-change-requests    #5920      +/-   ##
================================================================
+ Coverage                         97.39%   97.82%   +0.43%     
================================================================
  Files                              1191     1258      +67     
  Lines                             41552    44846    +3294     
================================================================
+ Hits                              40470    43872    +3402     
+ Misses                             1082      974     -108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kyle-ssg kyle-ssg changed the title Chore/componentise feature override row Chore: componentise feature override row Aug 12, 2025
@kyle-ssg kyle-ssg marked this pull request as draft August 12, 2025 13:08
@kyle-ssg kyle-ssg changed the base branch from feat/segment-change-requests to main August 12, 2025 13:09
@kyle-ssg kyle-ssg removed request for a team, Zaimwa9 and tiagoapolo August 12, 2025 13:09
@kyle-ssg kyle-ssg changed the base branch from main to feat/segment-page August 12, 2025 13:09
@github-actions github-actions bot added the chore label Nov 11, 2025
@github-actions github-actions bot added chore and removed chore labels Nov 11, 2025
@kyle-ssg kyle-ssg requested a review from Zaimwa9 November 11, 2025 10:11
Zaimwa9
Zaimwa9 previously approved these changes Nov 11, 2025
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 10

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Zaimwa9
Zaimwa9 previously approved these changes Nov 11, 2025
# Conflicts:
#	frontend/web/components/feature-summary/FeatureTags.tsx
#	frontend/web/components/pages/UserPage.tsx
{showSegmentOverride && (
<SegmentOverrideDescription
showEnabledOverride={hasEnabledDiff}
showValueOverride={!hasEnabledDiff}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incomplete Override Information

The showValueOverride prop is set to !hasEnabledDiff instead of hasValueDiff. When both the enabled state and value differ from the environment defaults (both segment overrides exist), only the enabled override message displays while the value override is hidden. This prevents users from seeing that the value is also being overridden by a segment.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API chore front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants