-
Notifications
You must be signed in to change notification settings - Fork 461
chore: componentise feature override row #5920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/segment-change-requests #5920 +/- ##
================================================================
+ Coverage 97.39% 97.82% +0.43%
================================================================
Files 1191 1258 +67
Lines 41552 44846 +3294
================================================================
+ Hits 40470 43872 +3402
+ Misses 1082 974 -108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Zaimwa9 <[email protected]>
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 10
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
# Conflicts: # frontend/web/components/feature-summary/FeatureTags.tsx # frontend/web/components/pages/UserPage.tsx
| {showSegmentOverride && ( | ||
| <SegmentOverrideDescription | ||
| showEnabledOverride={hasEnabledDiff} | ||
| showValueOverride={!hasEnabledDiff} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incomplete Override Information
The showValueOverride prop is set to !hasEnabledDiff instead of hasValueDiff. When both the enabled state and value differ from the environment defaults (both segment overrides exist), only the enabled override message displays while the value override is hidden. This prevents users from seeing that the value is also being overridden by a segment.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Migrates identity page feature row to a typescript component. This allows us to:
How did you test this code?
Note
Extracts a reusable feature override row (with CTA and override descriptions), replaces inline logic on UserPage, and adds supporting utils plus minor type/query/permission tweaks.
FeatureOverrideRow,FeatureOverrideCTA,IdentityOverrideDescription,MultivariateOverrideDescription,SegmentOverrideDescription.UserPageto useFeatureOverrideRow; removes duplicated toggle/value/override logic and related inline UI.common/featureValuesEqualfor comparing flag values.Utils.getOverridePermissionhelper and integrates withuseHasPermission.projectIdtypes tostring | numberin multiple components (IdentityTraits,CreateSegmentloader,TableTagFilter).skipand string coercion where needed.TableGroupsFilterdropsprojectIdprop.TableTagFiltersupports flexibleprojectIdand conditional tag fetching.Written by Cursor Bugbot for commit 3ee508e. This will update automatically on new commits. Configure here.