fix: dark mode on multi select component#6316
Merged
talissoncosta merged 2 commits intoNov 24, 2025
Merged
Conversation
- Add dark mode text and background colors to CustomOption, CustomMultiValue, and InlineMultiValue components - Implement helper functions (getOptionColors, getMultiValueColors) following existing codebase patterns - Add no-nested-ternary ESLint rule to prevent future code complexity issues - Fix text contrast issues in dark mode for better accessibility 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
front-end
Contributor
Docker builds report
|
Zaimwa9
approved these changes
Nov 21, 2025
talissoncosta
deleted the
fix/dark-mode-styling-missing-for-multiselect-component
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Fixed dark mode styling issues in the MultiSelect component where text was difficult or impossible to read due to poor contrast (dark text on dark backgrounds).
Updated components:
getOptionColors()helper function that applies dark mode background (#202839) on focus/hover and sets text color to white in dark modegetMultiValueColors()helper function to handle theme-aware colors for selected value chips when no custom color is providedCode quality improvements:
no-nested-ternary: errorESLint rule to prevent future code complexity issuesgetTagColor()inTag.tsx)The fix ensures proper text contrast in dark mode while maintaining existing functionality in light mode and with custom colors (via
colorMapprop).How did you test this code?
Manual testing:
Toggle dark mode on in the application settings
Navigate Segments
Steps to Reproduce:
On Rules tab, add and And condition
Select Environment Name, IN operator and then select and Environment.
Verify inline selected values (e.g., "Production") display with white text and are clearly readable
Open the MultiSelect dropdown
Hover over options and verify they show dark background with white text
Select multiple values and verify proper contrast
Toggle back to light mode and verify no visual regressions
Expected results:
Before:
Now:
Closes #6315