-
Notifications
You must be signed in to change notification settings - Fork 0
Job & Task 생성 및 조회 #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Job & Task 생성 및 조회 #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Job/Task 서비스 통합 - JobService, TaskService 삭제 - WorkflowService에 Job/Task CRUD 메서드 통합 - JobController, TaskController에서 WorkflowService 사용하도록 변경 2. Task 데이터 구조 확장 (9개 → 10개) - 새로운 Task 추가: "이미지 OCR 태스크" (ID: 8) - 기존 Task ID 변경: RAG 생성 (8→9), 블로그 발행 (9→10) - H2 테스트 데이터(03-insert-workflow-h2.sql) 업데이트 3. Integration 테스트 리팩토링 - JobApiIntegrationTest, TaskApiIntegrationTest에서 WorkflowService 사용 - Task 10개 구조에 맞춘 테스트 케이스 추가 - 새로운 OCR Task 및 업데이트된 블로그 발행 Task 테스트 추가 4. 코드 일관성 및 응집도 개선 - 워크플로우 관련 모든 CRUD 기능을 단일 서비스로 집중 - Job-Task 연결 구조 업데이트: Job1(Task 1-8), Job2(Task 9-10)
1. h2.sql task 9개 -> 10개 2. JobApiIntegrationTest는 모두 통과 3. TaskApiIntegrationTest는 자꾸 Json 직렬화 때문에 통과를 못함
- verify 호출 시 ArgumentMatchers.eq() 사용하여 InvalidUseOfMatchersException 해결 - workflowId 매개변수에 Matcher 적용으로 통합 테스트 안정화
…am-icebang into feature/task # Conflicts: # apps/user-service/src/test/java/site/icebang/integration/tests/workflow/WorkflowRunApiIntegrationTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🔗 관련 이슈
💬 추가 요청사항
✅ 체크리스트
코드 품질
테스트
배포 준비