Skip to content

BUGFIX: Keep fulltext index of hidden nodes as those may be searched in backend use cases #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUGFIX: Keep fulltext index of hidden nodes as those may be searched in backend use cases #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Classes/Driver/Version6/IndexerDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public function fulltext(NodeInterface $node, array $fulltextIndexOfNode, string
ctx._source.neos_fulltext_parts = new HashMap();
}

if (params.nodeIsRemoved || params.nodeIsHidden || params.fulltext.size() == 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If content from hidden nodes are added to the fulltext_parts, I assume they are automatically merged to the parent document where it is impossible to distinguish between content from hidden and not hidden node and the document would also be found by the originally hidden content.

if (params.nodeIsRemoved || params.fulltext.size() == 0) {
if (ctx._source.neos_fulltext_parts.containsKey(params.identifier)) {
ctx._source.neos_fulltext_parts.remove(params.identifier);
}
Expand All @@ -148,7 +148,6 @@ public function fulltext(NodeInterface $node, array $fulltextIndexOfNode, string
'params' => [
'identifier' => $node->getIdentifier(),
'nodeIsRemoved' => $node->isRemoved(),
'nodeIsHidden' => $node->isHidden(),
'fulltext' => $fulltextIndexOfNode
],
],
Expand Down