Skip to content

Conversation

@marcrobertscamao
Copy link

First implementation to exclude prefixes inline with #20

@mficzel mficzel requested review from kitsunet and mficzel October 18, 2023 14:51
@mficzel
Copy link
Member

mficzel commented Oct 18, 2023

@kitsunet i kindoff like the feature to get a readable configuration for a larger cookie zoo. What du you think?

mficzel
mficzel previously approved these changes Oct 18, 2023
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally like this and can confirm that it works as documented. My brain does not process array_reduce too well but that is probably more my personal issue.

@mficzel
Copy link
Member

mficzel commented Oct 18, 2023

After seeing pr #22 i changed my mind. I think the opt in approach via respect is cleaner concept wise.

@mficzel mficzel requested review from mficzel and removed request for kitsunet and mficzel October 18, 2023 15:08
@mficzel mficzel dismissed their stale review October 18, 2023 15:09

i prefer the apprach in #22

@mficzel
Copy link
Member

mficzel commented Oct 18, 2023

@marcrobertscamao would #22 solve your usecase aswell? It has a much simpler structure but kindoff turns the whole problem around.

@marcrobertscamao
Copy link
Author

@mficzel I think #22 should cover our needs, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants