Delete GP v0.6.7 from compatibility support #741
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis PR upgrades Gray Paper version support from 0.6.7/0.7.2-preview to stable 0.7.2. It removes the Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
packages/jam/jam-host-calls/accumulate/transfer.ts (2)
34-36: Remove version-conditional logic forbasicGasCost.This version check is inconsistent with the PR's objective to consolidate to 0.7.2 and eliminate version-gated logic. Since the codebase now targets 0.7.2 exclusively, this should use the simplified 0.7.2 behavior.
Apply this diff to remove the version check:
- basicGasCost = Compatibility.isGreaterOrEqual(GpVersion.V0_7_2) - ? tryAsSmallGas(10) - : (regs: IHostCallRegisters) => tryAsGas(10n + regs.get(TRANSFER_GAS_FEE_REG)); + basicGasCost = tryAsSmallGas(10);
69-75: Remove version-conditional logic inexecutemethod.This version check is inconsistent with the PR's objective to consolidate to 0.7.2 and eliminate version-gated branches. Since the codebase now targets 0.7.2 exclusively, the gas subtraction logic should always execute.
Apply this diff to remove the version check:
// All good! if (transferResult.isOk) { - if (Compatibility.isGreaterOrEqual(GpVersion.V0_7_2)) { - // substracting value `t` - const underflow = gas.sub(tryAsGas(transferGasFee)); - if (underflow) { - return PvmExecution.OOG; - } + // subtracting value `t` + const underflow = gas.sub(tryAsGas(transferGasFee)); + if (underflow) { + return PvmExecution.OOG; } regs.set(IN_OUT_REG, HostCallResult.OK); return;packages/jam/block/header.ts (2)
24-24: Update documentation link to current Gray Paper version.The link references
v=0.6.4, but this PR upgrades to version 0.7.2. Please update the version parameter in the URL to reflect the current version.As per coding guidelines.
-* https://graypaper.fluffylabs.dev/#/68eaa1f/0e34030e3603?v=0.6.4 +* https://graypaper.fluffylabs.dev/#/68eaa1f/0e34030e3603?v=0.7.2
97-97: Update documentation link to current Gray Paper version.The link references
v=0.6.4, but this PR upgrades to version 0.7.2. Please update the version parameter in the URL to reflect the current version.As per coding guidelines.
-* https://graypaper.fluffylabs.dev/#/68eaa1f/370202370302?v=0.6.4 +* https://graypaper.fluffylabs.dev/#/68eaa1f/370202370302?v=0.7.2packages/jam/block/work-package.ts (1)
13-13: Update documentation link to current Gray Paper version.The link references
v=0.6.4, but this PR upgrades to version 0.7.2. Please update the version parameter in the URL to reflect the current version.As per coding guidelines.
-/** Constrained by I=16 https://graypaper.fluffylabs.dev/#/68eaa1f/417a00417a00?v=0.6.4 */ +/** Constrained by I=16 https://graypaper.fluffylabs.dev/#/68eaa1f/417a00417a00?v=0.7.2 */
🧹 Nitpick comments (9)
packages/jam/state/test.utils.ts (3)
392-393: Consolidation looks good; add provenance/check to avoid drift.Great to pin TEST_AVAILABILITY_ASSIGNMENT to a single blob. Please add a short comment with the source (snapshot, block/hash) and optionally a quick decode/round‑trip sanity check in a nearby test to guard against accidental edits.
400-404: Mapping keyed at V0_7_1 while targeting 0.7.2.selectIfGreaterOrEqual will use the V0_7_1 entry for V0_7_2, which is fine. For clarity and future maintenance, consider adding an explicit [GpVersion.V0_7_2] entry (even if identical) or confirm that the 0.7.1 root is indeed unchanged in 0.7.2.
482-485: Ensure c10 payload stays in sync with TEST_AVAILABILITY_ASSIGNMENT.The updated c10 hex starts with 0x01…; verify it equals AvailabilityAssignment.Codec.encode(decoded(TEST_AVAILABILITY_ASSIGNMENT)) for 0.7.2. To prevent future divergence, consider generating this value programmatically in a test and asserting equality to this fixture.
packages/jam/transition/disputes/disputes.test.ts (1)
130-135: Address the commented test logic.The test logic for verifying cleared availability assignments is commented out with a TODO note. This reduces test coverage for the disputes transition.
Should this test logic be:
- Re-enabled with updated test data for 0.7.2?
- Moved to a separate issue/PR?
- Removed entirely if no longer applicable?
Would you like me to help regenerate the test data or open an issue to track this?
packages/jam/block/work-item.ts (1)
120-124: Avoid overshooting size hints for importSegmentsSetting typicalLength to MAX_NUMBER_OF_SEGMENTS likely overestimates encoded size and can degrade pre-allocation heuristics. Prefer a realistic typical (e.g., 0–16) or omit if not needed.
- importSegments: codecKnownSizeArray(ImportSpec.Codec, { - minLength: 0, - maxLength: MAX_NUMBER_OF_SEGMENTS, - typicalLength: MAX_NUMBER_OF_SEGMENTS, - }), + importSegments: codecKnownSizeArray(ImportSpec.Codec, { + minLength: 0, + maxLength: MAX_NUMBER_OF_SEGMENTS, + typicalLength: 16, // or remove if not representative + }),Also, ensure any graypaper.fluffylabs.dev links in this file target 0.7.2 or omit version pins if “latest” is intended. As per coding guidelines.
packages/jam/state/statistics.test.ts (2)
9-11: Skip rationale OK; consider pruning dead pathSince 0.6.7 is dropped, either remove this case or keep a clear TODO with target (issue/PR) to re-enable with 0.7.2 vectors. The current skip is fine.
16-16: Redundant suite override in a skipped test
Compatibility.overrideSuite(TestSuite.JAMDUNA)is inert underit.skip. Safe to remove or leave with a comment if you plan to revive this case.packages/jam/block/work-report.ts (1)
21-21: Update graypaper links to 0.7.2Links pinned to 0.6.x: please retarget to 0.7.2 (or drop the
v=to follow “latest”) to match this upgrade.- * https://graypaper.fluffylabs.dev/#/5f542d7/130e01130e01?v=0.6.2 + * https://graypaper.fluffylabs.dev/#/5f542d7/130e01130e01?v=0.7.2 ... - * https://graypaper.fluffylabs.dev/#/cc517d7/131c01132401?v=0.6.5 + * https://graypaper.fluffylabs.dev/#/cc517d7/131c01132401?v=0.7.2As per coding guidelines.
Also applies to: 55-56
packages/jam/state/statistics.ts (1)
84-86: Refresh graypaper links to 0.7.2Links pinned to 0.6.4 and 0.7.1 should target 0.7.2 (or remove version pin if “latest” is preferred) to match this PR’s scope. As per coding guidelines.
- * https://graypaper.fluffylabs.dev/#/68eaa1f/18f10318f103?v=0.6.4 + * https://graypaper.fluffylabs.dev/#/68eaa1f/18f10318f103?v=0.7.2 ... - * https://graypaper.fluffylabs.dev/#/1c979cb/199802199802?v=0.7.1 + * https://graypaper.fluffylabs.dev/#/1c979cb/199802199802?v=0.7.2Also applies to: 143-144
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (30)
.github/workflows/build-qa.yml(1 hunks).github/workflows/vectors-jamduna-067.yml(0 hunks).github/workflows/vectors-w3f-davxy-067.yml(0 hunks).github/workflows/vectors-w3f.yml(0 hunks)README.md(1 hunks)packages/core/utils/compatibility.test.ts(5 hunks)packages/core/utils/compatibility.ts(2 hunks)packages/jam/block/header.test.ts(1 hunks)packages/jam/block/header.ts(2 hunks)packages/jam/block/test-block-0-6-5.ts(0 hunks)packages/jam/block/test-helpers.ts(2 hunks)packages/jam/block/test-work-report-0-6-5.ts(0 hunks)packages/jam/block/work-item.ts(2 hunks)packages/jam/block/work-package.ts(2 hunks)packages/jam/block/work-report.ts(2 hunks)packages/jam/jam-host-calls/accumulate/transfer.ts(1 hunks)packages/jam/jam-host-calls/fetch.ts(1 hunks)packages/jam/jamnp-s/protocol/ce-133-work-package-submission.test.ts(2 hunks)packages/jam/safrole/safrole-seal-067.test.ts(0 hunks)packages/jam/safrole/safrole-seal.test.ts(1 hunks)packages/jam/state-merkleization/keys.ts(2 hunks)packages/jam/state-merkleization/serialized-state.ts(2 hunks)packages/jam/state-merkleization/state-entries.test.ts(1 hunks)packages/jam/state/statistics.test.ts(1 hunks)packages/jam/state/statistics.ts(3 hunks)packages/jam/state/test.utils.ts(2 hunks)packages/jam/transition/block-verifier.test.ts(3 hunks)packages/jam/transition/disputes/disputes.test.ts(3 hunks)packages/jam/transition/hasher.test.ts(2 hunks)packages/jam/transition/reports/verify-credentials.test.ts(2 hunks)
💤 Files with no reviewable changes (6)
- .github/workflows/vectors-jamduna-067.yml
- .github/workflows/vectors-w3f-davxy-067.yml
- packages/jam/safrole/safrole-seal-067.test.ts
- packages/jam/block/test-work-report-0-6-5.ts
- .github/workflows/vectors-w3f.yml
- packages/jam/block/test-block-0-6-5.ts
🧰 Additional context used
📓 Path-based instructions (2)
**/*.ts
⚙️ CodeRabbit configuration file
**/*.ts: rules from./CODESTYLE.mdshould be adhered to.
**/*.ts: Any function whose documentation mention it must not be used in production code,
can be safely used in*.test.tsfiles. Other usage should be carefuly reviewed
and the comment must explain why it's safe to use there.
**/*.ts:asconversions must not be used. Suggest usingtryAsconversion methods.
**/*.ts: Classes withstatic Codecfield must have private constructor and staticcreatemethod.
**/*.ts: Casting abigint(orU64) usingNumber(x)must have an explanation comment why
it is safe.
**/*.ts: When making changes to code with comments containing links (in classes, constants, methods, etc.)
to graypaper.fluffylabs.dev, ensure those links point to the current version for this update.
Files:
packages/jam/jam-host-calls/fetch.tspackages/jam/block/header.test.tspackages/jam/state/statistics.test.tspackages/jam/jam-host-calls/accumulate/transfer.tspackages/jam/safrole/safrole-seal.test.tspackages/jam/block/test-helpers.tspackages/jam/state-merkleization/serialized-state.tspackages/jam/block/header.tspackages/jam/transition/disputes/disputes.test.tspackages/jam/transition/reports/verify-credentials.test.tspackages/jam/block/work-item.tspackages/jam/jamnp-s/protocol/ce-133-work-package-submission.test.tspackages/core/utils/compatibility.test.tspackages/jam/state-merkleization/keys.tspackages/jam/transition/hasher.test.tspackages/jam/state-merkleization/state-entries.test.tspackages/jam/block/work-package.tspackages/jam/state/test.utils.tspackages/jam/state/statistics.tspackages/jam/block/work-report.tspackages/core/utils/compatibility.tspackages/jam/transition/block-verifier.test.ts
packages/core/**/*.ts
⚙️ CodeRabbit configuration file
packages/core/**/*.ts: Core packages must not import any JAM-related packages
(i.e. packages defined underpackages/jam/**)
Files:
packages/core/utils/compatibility.test.tspackages/core/utils/compatibility.ts
🧬 Code graph analysis (12)
packages/jam/state/statistics.test.ts (3)
packages/jam/config/chain-spec.ts (1)
tinyChainSpec(106-122)packages/core/codec/decoder.ts (1)
Decoder(12-379)packages/core/bytes/bytes.ts (1)
BytesBlob(18-171)
packages/jam/jam-host-calls/accumulate/transfer.ts (1)
packages/core/pvm-host-calls/host-call-handler.ts (1)
tryAsHostCallIndex(11-11)
packages/jam/safrole/safrole-seal.test.ts (10)
packages/jam/block/header.ts (1)
Header(112-173)packages/core/bytes/bytes.ts (1)
Bytes(176-242)packages/core/hash/hash.ts (2)
HASH_SIZE(10-10)HASH_SIZE(11-11)packages/jam/block/common.ts (4)
tryAsTimeSlot(18-18)tryAsValidatorIndex(23-23)tryAsPerValidator(56-62)tryAsPerEpochBlock(72-78)packages/core/crypto/bandersnatch.ts (6)
BANDERSNATCH_VRF_SIGNATURE_BYTES(10-10)BANDERSNATCH_VRF_SIGNATURE_BYTES(11-11)BANDERSNATCH_KEY_BYTES(6-6)BANDERSNATCH_KEY_BYTES(7-7)BLS_KEY_BYTES(22-22)BLS_KEY_BYTES(23-23)packages/jam/config/chain-spec.ts (1)
tinyChainSpec(106-122)packages/jam/block/utils.ts (1)
reencodeAsView(10-13)packages/jam/safrole/safrole-seal.ts (1)
SafroleSeal(32-165)packages/jam/state/validator-data.ts (3)
ValidatorData(27-51)VALIDATOR_META_BYTES(19-19)VALIDATOR_META_BYTES(20-20)packages/jam/state/safrole-data.ts (1)
SafroleSealingKeysData(30-91)
packages/jam/block/header.ts (3)
packages/jam/block/common.ts (3)
StateRootHash(43-43)TimeSlot(16-16)ValidatorIndex(21-21)packages/core/crypto/bandersnatch.ts (3)
BANDERSNATCH_VRF_SIGNATURE_BYTES(10-10)BANDERSNATCH_VRF_SIGNATURE_BYTES(11-11)BandersnatchVrfSignature(44-44)packages/core/crypto/ed25519.ts (3)
ED25519_KEY_BYTES(11-11)ED25519_KEY_BYTES(12-12)Ed25519Key(23-23)
packages/jam/transition/disputes/disputes.test.ts (3)
packages/core/codec/encoder.ts (1)
Encoder(73-480)packages/jam/block/work-report.ts (1)
WorkReport(105-127)packages/jam/config/chain-spec.ts (1)
tinyChainSpec(106-122)
packages/jam/block/work-item.ts (3)
packages/jam/block/common.ts (2)
ServiceId(26-26)ServiceGas(31-31)packages/jam/block/codec.ts (1)
codecKnownSizeArray(47-57)packages/jam/block/work-item-segment.ts (1)
MAX_NUMBER_OF_SEGMENTS(12-12)
packages/core/utils/compatibility.test.ts (1)
packages/core/utils/compatibility.ts (1)
Compatibility(47-106)
packages/jam/block/work-package.ts (4)
packages/jam/block/common.ts (1)
ServiceId(26-26)packages/jam/block/refine-context.ts (1)
RefineContext(53-90)packages/jam/block/work-item.ts (1)
WorkItem(112-175)packages/core/collections/sized-array.ts (1)
FixedSizeArray(18-54)
packages/jam/state/test.utils.ts (1)
packages/core/utils/compatibility.ts (1)
Compatibility(47-106)
packages/jam/state/statistics.ts (4)
packages/core/codec/descriptor.ts (1)
Descriptor(67-144)packages/jam/block/common.ts (2)
ServiceId(26-26)tryAsServiceId(28-28)packages/core/utils/compatibility.ts (1)
Compatibility(47-106)packages/core/numbers/index.ts (1)
tryAsU32(48-51)
packages/jam/block/work-report.ts (6)
packages/jam/block/refine-context.ts (2)
RefineContext(53-90)AuthorizerHash(15-15)packages/core/numbers/index.ts (2)
tryAsU32(48-51)isU16(45-45)packages/jam/block/common.ts (2)
tryAsCoreIndex(37-37)ServiceGas(31-31)packages/jam/block/work-result.ts (1)
WorkResult(118-163)packages/core/collections/sized-array.ts (1)
FixedSizeArray(18-54)packages/jam/block/work-package.ts (1)
tryAsWorkItemsCount(17-23)
packages/jam/transition/block-verifier.test.ts (1)
packages/core/utils/result.ts (2)
Result(4-4)Result(81-111)
🪛 GitHub Actions: Build - Lint & Test
packages/core/utils/compatibility.test.ts
[error] 52-52: File content differs from formatting output. ESLint/Prettier formatting mismatch detected during 'npm run qa'.
🪛 GitHub Actions: VECTORS - javajam
packages/core/utils/compatibility.ts
[error] 28-28: ReferenceError: Cannot access 'ALL_VERSIONS_IN_ORDER' before initialization in parseCurrentVersion.
🔇 Additional comments (34)
packages/jam/jam-host-calls/accumulate/transfer.ts (1)
23-23: LGTM! Static host-call index aligns with PR objectives.The change from dynamic version-dependent index resolution to a constant value correctly simplifies the code by removing version-conditional logic.
packages/jam/transition/hasher.test.ts (2)
25-25: LGTM: Clean removal of unused imports.The removal of
CompatibilityandGpVersionimports aligns with the elimination of version-gated test logic, leaving only the imports that are actually used in the test.
154-157: Verify the expected hash value is correct for version 0.7.2.The test now uses a single hard-coded expected hash instead of version-conditional logic. Please confirm that the test suite passes with this new expected value to ensure the hash is correct for the consolidated 0.7.2 codec implementation.
packages/jam/jamnp-s/protocol/ce-133-work-package-submission.test.ts (2)
10-10: LGTM - Clean import cleanup.Removing the unused
CompatibilityandGpVersionimports after eliminating version-guarded logic is appropriate.
50-51: LGTM - Version consolidation achieved.Replacing the version-guarded logic with a fixed hex constant for 0.7.2 correctly implements the PR objective to consolidate version support. The test is now simpler and eliminates runtime branching.
packages/jam/safrole/safrole-seal.test.ts (2)
1-24: LGTM!The imports and test setup are appropriate for the Safrole seal verification tests.
125-225: LGTM! Well-structured test data constants.The test data constants are properly structured:
TEST_VALIDATOR_KEYScorrectly usestryAsPerValidatorwith 6 validators matchingtinyChainSpecTEST_VALIDATOR_DATAappropriately extends keys with zero BLS keys and metadata (acceptable for seal verification testing)SEALING_KEYScorrectly usestryAsPerEpochBlockwith 12 keys matching the epoch lengthThe data is properly typed and parsed with appropriate opaque type conversions.
packages/jam/block/test-helpers.ts (2)
8-10: Changes are structurally correct but require manual verification of test data version.The simplification successfully removes version-gating logic as intended by the PR. However, the test data files (
test-block.tsandtest-work-report.ts) contain binary hex strings without version information, making it impossible to verify they represent 0.7.2 codec data through static analysis alone.Key findings:
- All version-gating conditionals removed from
testBlockHex()andtestWorkReportHex()- Legacy version-related imports removed
- No version-gating logic detected in consumer files
- Test data files unchanged (still valid exports)
Action required: Verify that
test-block.tsandtest-work-report.tsrepresent 0.7.2 codec data by checking the PR description, commit history, or the w3f spec reference mentioned in the file comment.
20-22: Verify that./test-work-report.tscontains 0.7.2 test data.The file exists and the simplification correctly mirrors
testBlockHex(). However, the exported hex string lacks explicit version documentation. Confirm that this test data corresponds to version 0.7.2 by cross-referencing with the w3f codec test files or project documentation.packages/jam/state-merkleization/serialized-state.ts (3)
3-3: LGTM! Type-only import is appropriate.BytesBlob is only used in type annotations throughout the file, making the type-only import correct and helping reduce bundle size.
8-8: LGTM! Type-only import is appropriate.U32 is only used in the type annotation for the
lenparameter (line 232), making the type-only import correct.
19-19: Import cleanup verified — no issues found.The removed imports (
GpVersion,Compatibility,safeAllocUint8Array,u32AsLeBytes) are not referenced anywhere in the file.TEST_COMPARE_USINGis correctly retained (line 19) and used (line 63). The simplifiedgetStorageimplementation directly usesserialize.serviceStoragewithout version branching, and all callers throughout the codebase work correctly with this change.packages/jam/state-merkleization/state-entries.test.ts (1)
59-64: Confirm test passes with updated hash before merging.The fallback hash change is logically sound: the new fallback (
0xcf33ddfb0987283f7614652d7eb4d3509e5efd93466a4b28ab4865cc912a66e1) is the same value that was previously mapped to V0_7_0, now promoted to cover all versions prior to V0_7_1. Removing V0_6_7 and V0_7_0 entries aligns with the PR objective to consolidate to 0.7.2 support.However, the npm test command failed in the sandbox (tsx unavailable). Please run the test locally to verify the updated expected hash produces the correct state root:
npm test -- --grep "should update the state"packages/jam/transition/reports/verify-credentials.test.ts (2)
9-9: LGTM: Import simplification aligns with version consolidation.Removing the
CompatibilityandGpVersionimports is appropriate as the tests no longer require version-conditional logic after consolidating to version 0.7.2.
225-225: Message format and construction logic are correct; hash value requires test verification.The hardcoded message on line 225 follows the correct format:
- Prefix verified:
0x6a616d5f67756172616e746565correctly encodes "jam_guarantee"- Structure verified: Constructed via
BytesBlob.blobFromParts(JAM_GUARANTEE, hash.raw)per thesigningPayload()function (verify-credentials.ts:121-123)- Gray Paper 0.7.2 alignment: Matches specification reference at https://graypaper.fluffylabs.dev/#/5f542d7/155200155200
The hash value (suffix) depends on the test work report generated from
newWorkReport({ core: 0 })via an external package. Verify the test passes during CI to confirm this hash is correctly computed from the test data.README.md (1)
16-17: LGTM!The checklist updates accurately reflect the completion of 0.7.1 and 0.7.2 support.
.github/workflows/build-qa.yml (1)
29-29: LGTM!The CI workflow correctly adds 0.7.2 testing, replacing the removed 0.6.7 and 0.7.2-preview test runs.
packages/jam/jam-host-calls/fetch.ts (1)
91-95: LGTM! Documentation updated to current version.The annotation and Gray Paper link have been correctly updated to reflect version 0.7.2 specification.
As per coding guidelines
packages/jam/state-merkleization/keys.ts (2)
7-7: LGTM! Import cleanup aligned with version consolidation.The removal of Compatibility and GpVersion imports is consistent with the removal of version-gated logic throughout the codebase.
40-47: LGTM! Enum expanded correctly.The addition of
Thetaand adjustment ofDeltaalign with the 0.7.2 specification.packages/core/utils/compatibility.test.ts (1)
47-82: LGTM! Test expectations updated correctly.The test assertions now use the updated version set (V0_7_0, V0_7_1, V0_7_2), which aligns with the enum changes in compatibility.ts.
packages/jam/transition/block-verifier.test.ts (3)
17-17: LGTM! Unnecessary imports removed.The removal of Compatibility and GpVersion imports is consistent with eliminating version-gated test logic.
128-132: LGTM! Test expectations now deterministic.Replacing version-conditional error messages with fixed expectations improves test clarity and maintainability.
196-196: LGTM! Fixed expected hash for 0.7.2.The test now expects a deterministic header hash value appropriate for the 0.7.2 version.
packages/jam/transition/disputes/disputes.test.ts (2)
13-13: LGTM! Unnecessary imports removed.Consistent with other test files, version-gating imports are no longer needed.
88-90: LGTM! Hash assertions now deterministic.The fixed hash values replace version-conditional assertions, making tests more predictable.
packages/core/utils/compatibility.ts (3)
1-5: LGTM! Version enum updated correctly.The removal of V0_6_7 and promotion of V0_7_2 from preview to stable aligns with the PR objectives.
13-13: LGTM! Default version updated.Setting DEFAULT_VERSION to V0_7_2 is correct for this upgrade.
34-45: LGTM! Suite parsing updated correctly.The parseCurrentSuite function correctly validates against the TestSuite enum values.
packages/jam/state/statistics.ts (2)
15-20: Suite-gated ServiceId codec: OKW3F_DAVXY → u32; otherwise varU32 with conversions. Looks consistent with current suites.
154-176: Rewritten Review Comment:Field order in fallback and V0_7_1 codecs is identical—there is no flip between versions. Verify that ServiceStatistics codec consumers handle the consistent layout correctly and add tests explicitly decoding both codec paths.
Likely an incorrect or invalid review comment.
packages/jam/block/header.test.ts (1)
34-35: Static expectations post‑unification verifiedVerification confirms no version gating remains. Test expectations at lines 34-35 and 38-39 are properly set as static hex strings for sealed and unsealed header encodings without any conditional logic or runtime version branching.
packages/jam/block/header.ts (1)
113-124: LGTM: Codec simplification is clean.The removal of version-conditional logic in favor of a single, explicit descriptor is a positive change that simplifies the codebase and improves maintainability.
packages/jam/block/work-package.ts (1)
38-48: LGTM: Version-agnostic codec is an improvement.The consolidation from version-conditional codec variants to a single, unified descriptor simplifies the codebase and eliminates potential version-related encoding inconsistencies.
| static Codec = codec.Class(WorkItem, { | ||
| service: codec.u32.asOpaque<ServiceId>(), | ||
| codeHash: codec.bytes(HASH_SIZE).asOpaque<CodeHash>(), | ||
| refineGasLimit: codec.u64.asOpaque<ServiceGas>(), | ||
| accumulateGasLimit: codec.u64.asOpaque<ServiceGas>(), | ||
| exportCount: codec.u16, | ||
| payload: codec.blob, | ||
| importSegments: codecKnownSizeArray(ImportSpec.Codec, { | ||
| minLength: 0, | ||
| maxLength: MAX_NUMBER_OF_SEGMENTS, | ||
| typicalLength: MAX_NUMBER_OF_SEGMENTS, | ||
| }), | ||
| extrinsic: codec.sequenceVarLen(WorkItemExtrinsicSpec.Codec), | ||
| }); |
There was a problem hiding this comment.
🧩 Analysis chain
Unified WorkItem.Codec LGTM; please confirm spec order
Field set matches the intended 0.7.2 shape (notably exportCount before payload). Please confirm against GP 0.7.2 to avoid a silent wire-compat drift.
🏁 Script executed:
#!/bin/bash
# Inspect WorkItem field ordering and ensure no leftover version gating in block codecs
rg -nP 'WorkItem.*Codec|V0_6_7|V0_7_0|Compatibility\.(is|isGreaterOrEqual)\(' packages/jam/block -C2Length of output: 1196
---
🏁 Script executed:
```shell
#!/bin/bash
# Check for documentation links and comments in work-item.ts that may need version updates
rg -nP 'greypa|graypaper|http|https|spec|0\.7' packages/jam/block/work-item.ts -C3
Length of output: 1227
---
🏁 Script executed:
```shell
#!/bin/bash
# Search for all graypaper links in codebase to identify version pattern and correct hash for 0.7.2
rg -nP 'graypaper\.fluffylabs\.dev.*#' packages/jam -A1 -B1 | head -100
Length of output: 7278
---
🏁 Script executed:
```shell
#!/bin/bash
# Search for 0.7.2 graypaper links to identify correct version hash
rg -nP 'graypaper\.fluffylabs\.dev.*0\.7\.2' packages/jam
Length of output: 3506
---
🏁 Script executed:
```shell
#!/bin/bash
# Get all graypaper links in work-item.ts to identify all that need updating
cat packages/jam/block/work-item.ts | grep -nP 'graypaper|http'
Length of output: 128
Update graypaper links to GP 0.7.2 in work-item.ts
The WorkItem.Codec structure is unified and correct. However, two graypaper documentation links in this file must be updated to point to GP 0.7.2:
- Line 31 (WorkItemExportedSegment.treeRoot): Change hash from
579bd12toab2cdbd - Line 110 (WorkItem class): Change hash from
579bd12toab2cdbd
Current links reference v=0.5.4; they must reflect the target version (0.7.2) per coding guidelines.
🤖 Prompt for AI Agents
In packages/jam/block/work-item.ts around lines 31 and 110 (and the codec block
shown at 113–126 for context), update the graypaper links that currently point
to v=0.5.4 with hash 579bd12: change the version to v=0.7.2 and replace the hash
579bd12 with ab2cdbd in both places (WorkItemExportedSegment.treeRoot at ~line
31 and the WorkItem class reference at ~line 110) so both links consistently
reference GP 0.7.2 with hash ab2cdbd.
| export class WorkReport extends WorkReportNoCodec { | ||
| static Codec: typeof WorkReportCodec = Compatibility.isGreaterOrEqual(GpVersion.V0_7_0) | ||
| ? WorkReportCodec | ||
| : WorkReportCodecPre070; | ||
| static Codec = codec.Class(WorkReportNoCodec, { | ||
| workPackageSpec: WorkPackageSpec.Codec, | ||
| context: RefineContext.Codec, | ||
| coreIndex: codec.varU32.convert( | ||
| (o) => tryAsU32(o), | ||
| (i) => { | ||
| if (!isU16(i)) { | ||
| throw new Error(`Core index exceeds U16: ${i}`); | ||
| } | ||
| return tryAsCoreIndex(i); | ||
| }, | ||
| ), | ||
| authorizerHash: codec.bytes(HASH_SIZE).asOpaque<AuthorizerHash>(), | ||
| authorizationGasUsed: codec.varU64.asOpaque<ServiceGas>(), | ||
| authorizationOutput: codec.blob, | ||
| segmentRootLookup: readonlyArray(codec.sequenceVarLen(WorkPackageInfo.Codec)), | ||
| results: codec.sequenceVarLen(WorkResult.Codec).convert( | ||
| (x) => x, | ||
| (items) => FixedSizeArray.new(items, tryAsWorkItemsCount(items.length)), | ||
| ), | ||
| }); |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
Bind Codec to WorkReport and align with ctor/create pattern
WorkReport.Codec = codec.Class(WorkReportNoCodec, …) instantiates the base type, not WorkReport, and violates our pattern (private constructor + static create on the class that holds Codec).
Apply:
- static Codec = codec.Class(WorkReportNoCodec, {
+ static Codec = codec.Class(WorkReport, {
workPackageSpec: WorkPackageSpec.Codec,
context: RefineContext.Codec,
coreIndex: codec.varU32.convert(
(o) => tryAsU32(o),
(i) => {
if (!isU16(i)) {
throw new Error(`Core index exceeds U16: ${i}`);
}
return tryAsCoreIndex(i);
},
),
authorizerHash: codec.bytes(HASH_SIZE).asOpaque<AuthorizerHash>(),
authorizationGasUsed: codec.varU64.asOpaque<ServiceGas>(),
authorizationOutput: codec.blob,
segmentRootLookup: readonlyArray(codec.sequenceVarLen(WorkPackageInfo.Codec)),
results: codec.sequenceVarLen(WorkResult.Codec).convert(
(x) => x,
(items) => FixedSizeArray.new(items, tryAsWorkItemsCount(items.length)),
),
});Then add inside class WorkReport:
// Ensure consumers get WorkReport instances
static create(v: CodecRecord<WorkReport>) {
return new WorkReport(
v.workPackageSpec,
v.context,
v.coreIndex,
v.authorizerHash,
v.authorizationOutput,
v.segmentRootLookup,
v.results,
v.authorizationGasUsed,
);
}
private constructor(
workPackageSpec: WorkPackageSpec,
context: RefineContext,
coreIndex: CoreIndex,
authorizerHash: AuthorizerHash,
authorizationOutput: BytesBlob,
segmentRootLookup: readonly WorkPackageInfo[],
results: FixedSizeArray<WorkResult, WorkItemsCount>,
authorizationGasUsed: ServiceGas,
) {
super(
workPackageSpec,
context,
coreIndex,
authorizerHash,
authorizationOutput,
segmentRootLookup,
results,
authorizationGasUsed,
);
}As per coding guidelines.
🏁 Script executed:
#!/bin/bash
# Find usages that rely on WorkReport identity
rg -nP 'instanceof\s+WorkReport|WorkReport\.create|codec\.Class\(WorkReportNoCodec' -C2Length of output: 5390
---
🏁 Script executed:
```shell
#!/bin/bash
# Inspect the actual WorkReport class definition
cat packages/jam/block/work-report.ts | head -150
Length of output: 4444
🏁 Script executed:
#!/bin/bash
# Also check if WorkReportNoCodec has a create method or constructor
rg -n 'class WorkReportNoCodec|static create|private constructor' packages/jam/block/work-report.ts -A5Length of output: 690
---
🏁 Script executed:
```shell
#!/bin/bash
# Check if any code explicitly types/expects WorkReportNoCodec
rg -n 'WorkReportNoCodec' packages/jam -g '!*.ts' --type=ts -C2 | head -80
Length of output: 0
🏁 Script executed:
#!/bin/bash
# Check if Codec is used elsewhere and how
rg -n 'WorkReport\.Codec' packages/jam --type=ts -C2Length of output: 7085
---
🏁 Script executed:
```shell
#!/bin/bash
# Check graypaper links in work-report.ts
rg -n 'graypaper\.fluffylabs\.dev' packages/jam/block/work-report.ts
Length of output: 205
---
🏁 Script executed:
```shell
#!/bin/bash
# Check what graypaper versions are used elsewhere in the codebase
rg 'graypaper\.fluffylabs\.dev.*\?v=' packages/jam --type=ts | cut -d'=' -f2 | sort | uniq -c | sort -rn
Length of output: 471
Bind Codec to WorkReport, add factory pattern, and update graypaper links
The current WorkReport.Codec = codec.Class(WorkReportNoCodec, …) violates the guideline: classes with static Codec must have private constructor and static create method. The Codec produces WorkReportNoCodec instances, not WorkReport, causing all 12+ inherited create() calls to return the base type instead of the derived type.
Essential refactor: Bind Codec to WorkReport, add private constructor and static create override:
- static Codec = codec.Class(WorkReportNoCodec, {
+ static Codec = codec.Class(WorkReport, {
workPackageSpec: WorkPackageSpec.Codec,
context: RefineContext.Codec,
coreIndex: codec.varU32.convert(
(o) => tryAsU32(o),
(i) => {
if (!isU16(i)) {
throw new Error(`Core index exceeds U16: ${i}`);
}
return tryAsCoreIndex(i);
},
),
authorizerHash: codec.bytes(HASH_SIZE).asOpaque<AuthorizerHash>(),
authorizationGasUsed: codec.varU64.asOpaque<ServiceGas>(),
authorizationOutput: codec.blob,
segmentRootLookup: readonlyArray(codec.sequenceVarLen(WorkPackageInfo.Codec)),
results: codec.sequenceVarLen(WorkResult.Codec).convert(
(x) => x,
(items) => FixedSizeArray.new(items, tryAsWorkItemsCount(items.length)),
),
});
+
+ static create(v: CodecRecord<WorkReport>) {
+ return new WorkReport(
+ v.workPackageSpec,
+ v.context,
+ v.coreIndex,
+ v.authorizerHash,
+ v.authorizationOutput,
+ v.segmentRootLookup,
+ v.results,
+ v.authorizationGasUsed,
+ );
+ }
+
+ private constructor(
+ workPackageSpec: WorkPackageSpec,
+ context: RefineContext,
+ coreIndex: CoreIndex,
+ authorizerHash: AuthorizerHash,
+ authorizationOutput: BytesBlob,
+ segmentRootLookup: readonly WorkPackageInfo[],
+ results: FixedSizeArray<WorkResult, WorkItemsCount>,
+ authorizationGasUsed: ServiceGas,
+ ) {
+ super(
+ workPackageSpec,
+ context,
+ coreIndex,
+ authorizerHash,
+ authorizationOutput,
+ segmentRootLookup,
+ results,
+ authorizationGasUsed,
+ );
+ }Update graypaper links to current version (0.7.2):
- Line 21: change
?v=0.6.2to?v=0.7.2 - Line 55: change
?v=0.6.5to?v=0.7.2 - Line 93: add
?v=0.7.2to the segment-root lookup link
Committable suggestion skipped: line range outside the PR's diff.
| it("should verify a valid fallback mode seal and entropySource", async () => { | ||
| // based on test-vectors/w3f-davxy_070/traces/fallback/00000002.json | ||
| const header = Header.create({ | ||
| parentHeaderHash: Bytes.parseBytes( | ||
| "0x74ad675f8d6480a17b6ec0178962ea0166053c384689044c6f4cd38c97c2776d", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| priorStateRoot: Bytes.parseBytes( | ||
| "0x4542b8bd55b25f52767e37c1c72004fefdd068878084e9c87c3ab0dc38543173", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| extrinsicHash: Bytes.parseBytes( | ||
| "0x189d15af832dfe4f67744008b62c334b569fcbb4c261e0f065655697306ca252", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| timeSlotIndex: tryAsTimeSlot(2), | ||
| epochMarker: null, | ||
| ticketsMarker: null, | ||
| offendersMarker: [], | ||
| bandersnatchBlockAuthorIndex: tryAsValidatorIndex(3), | ||
| entropySource: Bytes.parseBytes( | ||
| "0x21237c35f11cd849a27ffa62e4aeb1c9a06bca2e42b89e16f93932d773b4ed5e7df1d7c48986eeb1313462aec31668dbfa6d3e499b457c678320ce0bb0fb611be3b6b240e1cd757e624d50cb1a163ca5c6348f97b782f5db74f8877eae593a0d", | ||
| BANDERSNATCH_VRF_SIGNATURE_BYTES, | ||
| ).asOpaque(), | ||
| seal: Bytes.parseBytes( | ||
| "0x732cef37ec4d9f100aca7445a486afc3fa1015056e3377905168e7b88d40286e68d943e77c0e5f5539c40416cd494b50aeb227ba55701d64e5586c790aebc60c1eba819c07c1b6f8fbca0d7765caaa61e494271c925df7ee42e6a19b0d3d2313", | ||
| BANDERSNATCH_VRF_SIGNATURE_BYTES, | ||
| ).asOpaque(), | ||
| }); | ||
| const spec = tinyChainSpec; | ||
| const headerView = reencodeAsView(Header.Codec, header, spec); | ||
|
|
||
| const safroleSeal = new SafroleSeal(bandersnatch); | ||
| const result = await safroleSeal.verifyHeaderSeal(headerView, { | ||
| currentValidatorData: TEST_VALIDATOR_DATA, | ||
| sealingKeySeries: SEALING_KEYS, | ||
| currentEntropy: Bytes.parseBytes( | ||
| "0x405c80c1f6a2d5a0f8dbc56996f04230221100d9500244648f02a795d7850eac", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| }); | ||
| const safroleSeal = new SafroleSeal(bandersnatch); | ||
| const result = await safroleSeal.verifyHeaderSeal(headerView, { | ||
| currentValidatorData: TEST_VALIDATOR_DATA, | ||
| sealingKeySeries: SEALING_KEYS, | ||
| currentEntropy: Bytes.parseBytes( | ||
| "0x405c80c1f6a2d5a0f8dbc56996f04230221100d9500244648f02a795d7850eac", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| }); | ||
|
|
||
| assert.deepStrictEqual(result, { | ||
| isError: false, | ||
| isOk: true, | ||
| ok: Bytes.parseBytes( | ||
| "0xc13af3d0cbdb7174590f34518e3beb05708935ceaee242e7ba11a94ca87bd007", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| }); | ||
| assert.deepStrictEqual(result, { | ||
| isError: false, | ||
| isOk: true, | ||
| ok: Bytes.parseBytes("0xc13af3d0cbdb7174590f34518e3beb05708935ceaee242e7ba11a94ca87bd007", HASH_SIZE).asOpaque(), | ||
| }); | ||
| }); | ||
|
|
||
| it("should verify a valid ticket seal and entropySource", async () => { | ||
| // based on test-vectors/w3f-davxy_070/traces/safrole/00000002.json | ||
| const header = Header.create({ | ||
| parentHeaderHash: Bytes.parseBytes( | ||
| "0x74ad675f8d6480a17b6ec0178962ea0166053c384689044c6f4cd38c97c2776d", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| priorStateRoot: Bytes.parseBytes( | ||
| "0x4542b8bd55b25f52767e37c1c72004fefdd068878084e9c87c3ab0dc38543173", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| extrinsicHash: Bytes.parseBytes( | ||
| "0x189d15af832dfe4f67744008b62c334b569fcbb4c261e0f065655697306ca252", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| timeSlotIndex: tryAsTimeSlot(2), | ||
| epochMarker: null, | ||
| ticketsMarker: null, | ||
| offendersMarker: [], | ||
| bandersnatchBlockAuthorIndex: tryAsValidatorIndex(3), | ||
| entropySource: Bytes.parseBytes( | ||
| "0x21237c35f11cd849a27ffa62e4aeb1c9a06bca2e42b89e16f93932d773b4ed5e7df1d7c48986eeb1313462aec31668dbfa6d3e499b457c678320ce0bb0fb611be3b6b240e1cd757e624d50cb1a163ca5c6348f97b782f5db74f8877eae593a0d", | ||
| BANDERSNATCH_VRF_SIGNATURE_BYTES, | ||
| ).asOpaque(), | ||
| seal: Bytes.parseBytes( | ||
| "0x732cef37ec4d9f100aca7445a486afc3fa1015056e3377905168e7b88d40286e68d943e77c0e5f5539c40416cd494b50aeb227ba55701d64e5586c790aebc60c1eba819c07c1b6f8fbca0d7765caaa61e494271c925df7ee42e6a19b0d3d2313", | ||
| BANDERSNATCH_VRF_SIGNATURE_BYTES, | ||
| ).asOpaque(), | ||
| }); | ||
| const spec = tinyChainSpec; | ||
| const headerView = reencodeAsView(Header.Codec, header, spec); | ||
| it("should verify a valid ticket seal and entropySource", async () => { | ||
| // based on test-vectors/w3f-davxy_070/traces/safrole/00000002.json | ||
| const header = Header.create({ | ||
| parentHeaderHash: Bytes.parseBytes( | ||
| "0x74ad675f8d6480a17b6ec0178962ea0166053c384689044c6f4cd38c97c2776d", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| priorStateRoot: Bytes.parseBytes( | ||
| "0x4542b8bd55b25f52767e37c1c72004fefdd068878084e9c87c3ab0dc38543173", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| extrinsicHash: Bytes.parseBytes( | ||
| "0x189d15af832dfe4f67744008b62c334b569fcbb4c261e0f065655697306ca252", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| timeSlotIndex: tryAsTimeSlot(2), | ||
| epochMarker: null, | ||
| ticketsMarker: null, | ||
| offendersMarker: [], | ||
| bandersnatchBlockAuthorIndex: tryAsValidatorIndex(3), | ||
| entropySource: Bytes.parseBytes( | ||
| "0x21237c35f11cd849a27ffa62e4aeb1c9a06bca2e42b89e16f93932d773b4ed5e7df1d7c48986eeb1313462aec31668dbfa6d3e499b457c678320ce0bb0fb611be3b6b240e1cd757e624d50cb1a163ca5c6348f97b782f5db74f8877eae593a0d", | ||
| BANDERSNATCH_VRF_SIGNATURE_BYTES, | ||
| ).asOpaque(), | ||
| seal: Bytes.parseBytes( | ||
| "0x732cef37ec4d9f100aca7445a486afc3fa1015056e3377905168e7b88d40286e68d943e77c0e5f5539c40416cd494b50aeb227ba55701d64e5586c790aebc60c1eba819c07c1b6f8fbca0d7765caaa61e494271c925df7ee42e6a19b0d3d2313", | ||
| BANDERSNATCH_VRF_SIGNATURE_BYTES, | ||
| ).asOpaque(), | ||
| }); | ||
| const spec = tinyChainSpec; | ||
| const headerView = reencodeAsView(Header.Codec, header, spec); | ||
|
|
||
| const safroleSeal = new SafroleSeal(bandersnatch); | ||
| const result = await safroleSeal.verifyHeaderSeal(headerView, { | ||
| currentValidatorData: TEST_VALIDATOR_DATA, | ||
| sealingKeySeries: SEALING_KEYS, | ||
| currentEntropy: Bytes.parseBytes( | ||
| "0x405c80c1f6a2d5a0f8dbc56996f04230221100d9500244648f02a795d7850eac", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| }); | ||
| const safroleSeal = new SafroleSeal(bandersnatch); | ||
| const result = await safroleSeal.verifyHeaderSeal(headerView, { | ||
| currentValidatorData: TEST_VALIDATOR_DATA, | ||
| sealingKeySeries: SEALING_KEYS, | ||
| currentEntropy: Bytes.parseBytes( | ||
| "0x405c80c1f6a2d5a0f8dbc56996f04230221100d9500244648f02a795d7850eac", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| }); | ||
|
|
||
| assert.deepStrictEqual(result, { | ||
| isError: false, | ||
| isOk: true, | ||
| ok: Bytes.parseBytes( | ||
| "0xc13af3d0cbdb7174590f34518e3beb05708935ceaee242e7ba11a94ca87bd007", | ||
| HASH_SIZE, | ||
| ).asOpaque(), | ||
| }); | ||
| assert.deepStrictEqual(result, { | ||
| isError: false, | ||
| isOk: true, | ||
| ok: Bytes.parseBytes("0xc13af3d0cbdb7174590f34518e3beb05708935ceaee242e7ba11a94ca87bd007", HASH_SIZE).asOpaque(), | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Critical: Duplicate test with misleading description - missing ticket mode coverage.
Both test cases are completely identical in implementation and use the same SEALING_KEYS constant, which is created via SafroleSealingKeysData.keys() (line 171). According to the SafroleSealingKeysData implementation, .keys() creates fallback mode (kind = SafroleSealingKeysKind.Keys), not ticket mode.
This means:
- Both tests are verifying fallback mode seal verification, despite the second test claiming to test "ticket seal"
- There is no actual test coverage for ticket-based seal verification (regular Safrole mode)
- The second test provides no additional value over the first
To properly test ticket mode, the second test should:
- Use
SafroleSealingKeysData.tickets()instead of.keys() - Use appropriate ticket data matching the test vector from "safrole/00000002.json"
- Likely have different expected results
Consider creating a separate TICKET_SEALING_KEYS constant using SafroleSealingKeysData.tickets() with proper ticket data, and update the second test to use it. Alternatively, if both test vectors genuinely use fallback mode, update the second test's description to reflect this, though this would still leave ticket mode verification untested.
.github/workflows/vectors-w3f.yml
Outdated
There was a problem hiding this comment.
We can't delete that. There are many tests that are not present in any other place. We should rather start using 0.7.0 for these and ignore the tests that are updated in other locations.
| authorizationGasUsed: codec.varU64.asOpaque<ServiceGas>(), | ||
| }); | ||
|
|
||
| export class WorkReport extends WorkReportNoCodec { |
There was a problem hiding this comment.
Base class is no longer needed.
| // TODO [MaSo] Tests only for 0.6.7: which is not supported. | ||
| it.skip("should decode statistics data 1 with no error", () => { |
There was a problem hiding this comment.
What are we supposed to do with that TODO? Either make them work or remove if they are no longer valid.
| (i) => tryAsServiceId(i), | ||
| ); | ||
| const codecServiceId: Descriptor<ServiceId> = Compatibility.isSuite(TestSuite.W3F_DAVXY) | ||
| ? codec.u32.asOpaque<ServiceId>() |
There was a problem hiding this comment.
Can you double check if this is still needed? I think at some point GP was specifying var-len encoding, but hopefuly that should be fixed now and we don't need this special-casing?
| extrinsicSize: codec.varU32, | ||
| exports: codecVarU16, |
There was a problem hiding this comment.
To avoid errors this should rather match the codec.
| // if (stateUpdate !== undefined) { | ||
| // const clearedAvailabilityAssignment = stateUpdate.availabilityAssignment; | ||
| // assert.strictEqual(clearedAvailabilityAssignment[0], null); | ||
| // assert.strictEqual(clearedAvailabilityAssignment[1], availabilityAssignment2); | ||
| // } |
There was a problem hiding this comment.
Please skip the entire test without commenting out the assertions.
View all
Benchmarks summary: 63/63 OK ✅ |
Resolves #715