added .mb file for mnist cnn#186
Open
Akshat-mehrotra wants to merge 4 commits into
Open
Conversation
made a .mb file for the convolution network implementation of the MNIST recognition task. Added the updated source code file too.
Member
|
Hey @Akshat-mehrotra the ".jl" should be combined with the existing ".jl" file rather than it being deleted. So at the end of this Pull request, you will have one added file and then one edited file (the original ".jl" file) |
Member
|
Let me know if that does not make sense or you have questions! Keep up the great work. |
Author
|
did the edits required |
Author
|
Yea i fixed that
…On Thu, 2 Jan, 2020, 10:07 AM Logan Kilpatrick, ***@***.***> wrote:
Let me know if that does not make sense or you have questions! Keep up the
great work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#186?email_source=notifications&email_token=AGJALB5VE5MNFWAKNDVTZHTQ3VVRXA5CNFSM4KB5BPX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5UVGA#issuecomment-570116760>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJALB7AYO4NBDQVUX3NK73Q3VVRXANCNFSM4KB5BPXQ>
.
|
Member
|
It would be nice if it was a Weave.jl .jmd fil. |
Author
|
hey can you review that task. I've completed other tasks and want to submit
them.
On Thu, 2 Jan, 2020, 2:36 PM Akshat Mehrotra, <akshatmehrotra2004@gmail.com>
wrote:
… Yea i fixed that
On Thu, 2 Jan, 2020, 10:07 AM Logan Kilpatrick, ***@***.***>
wrote:
> Let me know if that does not make sense or you have questions! Keep up
> the great work.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#186?email_source=notifications&email_token=AGJALB5VE5MNFWAKNDVTZHTQ3VVRXA5CNFSM4KB5BPX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5UVGA#issuecomment-570116760>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJALB7AYO4NBDQVUX3NK73Q3VVRXANCNFSM4KB5BPXQ>
> .
>
|
Author
|
I was told to use literate.jl for the documentation. |
Author
|
I could change it to weave.jl. however, it might take some time as I'm out of town right now |
Member
|
Literate.jl should be fine, since that's what we use for generating the notebooks. |
Author
|
So can this PR be merged now |
Added the Conv net for judge a book by its cover task
Author
|
sorry about the commits. Accidentally pushed on the wrong branch. They have been reverted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
made a .mb file for the convolution network implementation of the MNIST recognition task. Added the updated source code file too.