Annotation for Character RNN #189
Open
chinglamchoi wants to merge 6 commits into
Open
Conversation
logankilpatrick
left a comment
logankilpatrick
left a comment
Member
There was a problem hiding this comment.
This should help people! Nice job.
Author
|
Thank you!! |
| # # 2. Data Download & Pre-processing | ||
| # - Source of data: Shakespeare text from https://cs.stanford.edu/people/karpathy/char-rnn/ | ||
| # - Generate character tokens | ||
| # - Partition in batches for input |
Member
There was a problem hiding this comment.
Probably good to talk about how these batches are divided. The comments in the code blocks would do well as Markdown cells that detail the why and how in a couple lines
Author
There was a problem hiding this comment.
Sure! I'll add these details in a few days' time if you don't mind, it's actually testing/examination period for my school!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.