Skip to content

fix(datasource_activerecord): implement blank, present & missing filter operators with proper string handling - #145

Closed
matthv wants to merge 2 commits into
mainfrom
fix/blank-operator
Closed

matthv wants to merge 2 commits into
mainfrom
fix/blank-operator

Conversation

@matthv

@matthv matthv commented Oct 13, 2025

Copy link
Copy Markdown
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh

qltysh Bot commented Oct 13, 2025

Copy link
Copy Markdown

2 new issues

Tool Category Rule Count
qlty Structure Function with high complexity (count = 7): compute_main_operator 1
qlty Structure Function with many parameters (count = 4): build_comparison_query 1

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@qltysh

qltysh Bot commented Oct 13, 2025

Copy link
Copy Markdown

Diff Coverage: The code coverage on the diff in this pull request is 42.1%.

Total Coverage: This PR will decrease coverage by 0.09%.

File Coverage Changes
Path File Coverage Δ Indirect
packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query.rb 1.9
packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/operators.rb 0.1
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@matthv
matthv force-pushed the fix/blank-operator branch from bfdc8a1 to 116a63a Compare October 14, 2025 08:42
field
end

def build_comparison_query(original_field, formatted_field, value, operator)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): build_comparison_query [qlty:function-parameters]

@matthv matthv closed this Oct 14, 2025
@matthv
matthv deleted the fix/blank-operator branch October 14, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant