fix(list): removes null values in included records - #147
Conversation
2 new issues
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
|
Diff Coverage: The code coverage on the diff in this pull request is 100.0%. Total Coverage: This PR will increase coverage by 0.13%. File Coverage Changes
🛟 Help
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes null value handling in serialized responses by preventing null relationships from being included in the JSON output. The changes remove the explicit data: nil entries from relationship objects when the relationship is empty or null.
- Removes null relationship data from serialized output instead of explicitly setting it to nil
- Updates attribute serialization to skip nil values for included records unless the key explicitly exists
- Modifies test expectations to reflect the absence of null data fields
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer.rb | Updates serialization logic to omit null relationships and attributes instead of explicitly setting them to nil |
| packages/forest_admin_agent/spec/lib/forest_admin_agent/routes/resources/store_spec.rb | Updates test expectations to remove assertions for null data fields in relationships |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
## [1.8.7](v1.8.6...v1.8.7) (2025-10-20) ### Bug Fixes * **list:** removes null values in included records ([#147](#147)) ([26cf793](26cf793))
|
🎉 This PR is included in version 1.8.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.8.7](v1.8.6...v1.8.7) (2025-10-20) ### Bug Fixes * **list:** removes null values in included records ([#147](#147)) ([26cf793](26cf793))
Definition of Done
ticket clickup: https://app.clickup.com/t/86c5ww31k
General
Security