Prevent parallel file lock clear #3714
Conversation
FDBDirectory: When file lock clear is called in parallel by multiple threads, synchronically waiting for the first thread's clear to complete seems to be a better strategy. Resolves FoundationDB#3713
| } | ||
|
|
||
| private void fileLockClearFlushAndClose(boolean isRecovery) { | ||
| synchronized (clearingLockNowLock) { |
There was a problem hiding this comment.
Teamscale is reporting that this test is uncovered: https://fdb.teamscale.io/activity/merge-requests/foundationdb-fdb-record-layer/FoundationDB%2Ffdb-record-layer%2F3714
Given that teamscale is not reporting back to PRs right now, it's possible that it is a matter of closing.
This could be an indication that some lower-level tests of FDBDirectoryLockFactory are needed, particularly covering the parallelism indicated in the PR description.
There was a problem hiding this comment.
I had something wrong with my teamscale configuration, and it was only showing mixed-mode test coverage, which of course would be 0.
Teamscale is now reporting back.
There was a problem hiding this comment.
So is this code covered by tests?
ScottDugas
requested review from
ScottDugas
and removed request for
ScottDugas
2 participants
FDBDirectory: When file lock clear is called in parallel by multiple threads, synchronically waiting for the first thread's clear to complete seems to be a better strategy.
Resolves #3713