-
Notifications
You must be signed in to change notification settings - Fork 2
Add_ freeCodeCampVid bibliography.md #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated list to: -[x] Include freeCodeCamp Youtube video Highly debatable location, but it was a great resource that encouraged me to try my first pull request here. Seeing it in action, how the UI is navigated it very helpful for someone like myself.
|
Thank you @BenWeberStorWater, good job submitting your first PR! 😺
The location is totally fine. Ideally, we will add a mew reference in the bibliography when citing an external link in a document we are writing. However, we still don't have a document describing the basics about the GitHub' UI (And it's totally not the goal writing a whole document in your first PR). Don't worry about the check that is not passing (DCO). I'm explaining that next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is your first chance to implement a round of feedback during a code review. Animo!
Please implement the requested changes, and request a new round of review in the reviewers section on the top right corner of the PR UI.
| #### Pull Requests (PR) | ||
| ```{eval-rst} | ||
| .. [quick_rundown_video] | ||
| freeCodeCamp Youtube Video to understand basic UI of GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| freeCodeCamp Youtube Video to understand basic UI of GitHub | |
| FreeCodeCamp YouTube video to understand the basics about the UI of GitHub |
Please capitalize the start of the sentence (Unless the company is actually called freeCodeCamp and the lower "f" is intentional.
Also, let's try to phrase the sentence in a more natural & noob friendly language. You are a native English speaker, so you'll do better than me.
It would be super nice if you add a few bullet points describing the contents of the video, so people understand a bit better what they will watching when clicking the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "f" is lower case because it is a specific name.
I will add bullet points in the coming week about the video, as I watch it again.
Updated list to:
-[x] Include freeCodeCamp Youtube video
Highly debatable location, but it was a great resource that encouraged me to try my first pull request here.
Seeing it in action, how the UI is navigated it very helpful for someone like myself.