Skip to content

Conversation

@benslackin
Copy link

Updated list to:

-[x] Include freeCodeCamp Youtube video

Highly debatable location, but it was a great resource that encouraged me to try my first pull request here.

Seeing it in action, how the UI is navigated it very helpful for someone like myself.

Updated list to:

-[x] Include freeCodeCamp Youtube video

Highly debatable location, but it was a great resource that encouraged me to try my first pull request here. 

Seeing it in action, how the UI is navigated it very helpful for someone like myself.
@Guillemdb
Copy link
Member

Guillemdb commented Feb 26, 2021

Thank you @BenWeberStorWater, good job submitting your first PR! 😺

Highly debatable location

The location is totally fine. Ideally, we will add a mew reference in the bibliography when citing an external link in a document we are writing. However, we still don't have a document describing the basics about the GitHub' UI (And it's totally not the goal writing a whole document in your first PR).

Don't worry about the check that is not passing (DCO). I'm explaining that next week.

@Guillemdb Guillemdb self-requested a review February 26, 2021 07:25
Copy link
Member

@Guillemdb Guillemdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is your first chance to implement a round of feedback during a code review. Animo!

Please implement the requested changes, and request a new round of review in the reviewers section on the top right corner of the PR UI.

#### Pull Requests (PR)
```{eval-rst}
.. [quick_rundown_video]
freeCodeCamp Youtube Video to understand basic UI of GitHub
Copy link
Member

@Guillemdb Guillemdb Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
freeCodeCamp Youtube Video to understand basic UI of GitHub
FreeCodeCamp YouTube video to understand the basics about the UI of GitHub

Please capitalize the start of the sentence (Unless the company is actually called freeCodeCamp and the lower "f" is intentional.

Also, let's try to phrase the sentence in a more natural & noob friendly language. You are a native English speaker, so you'll do better than me.

It would be super nice if you add a few bullet points describing the contents of the video, so people understand a bit better what they will watching when clicking the link.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "f" is lower case because it is a specific name.

I will add bullet points in the coming week about the video, as I watch it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants