clang-tidy: resolve modernize-use-nullptr#592
Conversation
There was a problem hiding this comment.
Pull request overview
Mechanical clang-tidy cleanup that replaces literal 0 initializers with nullptr for pointer fields in the Python plugin's PyTypeObject definitions and a few local PyObject* variables, satisfying the modernize-use-nullptr check.
Changes:
- Replace
0withnullptrinPyTypeObjectslot initializers across four Python wrapper translation units. - Replace
0withnullptrin localPyObject*initializations inparse_argsandsc_provide.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/python/src/modulewrap.cpp | nullptr for PyObject* locals and PhlexModule_Type/PhlexSource_Type slots. |
| plugins/python/src/lifelinewrap.cpp | nullptr for pointer slots in PhlexLifeline_Type. |
| plugins/python/src/dciwrap.cpp | nullptr for pointer slots in PhlexDataCellIndex_Type. |
| plugins/python/src/configwrap.cpp | nullptr for pointer slots in PhlexConfig_Type. |
|
It'd be nice if the comment lines in the type object declarations can be kept lined-up after this chance. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 82.16% 82.16%
=======================================
Files 157 157
Lines 5719 5720 +1
Branches 646 646
=======================================
+ Hits 4699 4700 +1
- Misses 807 808 +1
+ Partials 213 212 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@phlexbot format |
|
No automatic format fixes were necessary. |
@wlav, can you take a look and approve if it looks good to you? |
No description provided.