Add a note about the BOARD_ID logic #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Module detection is done using the BOARD_ID pin. It is possible to override this setting on the system, but at the risk of shorting the system | ||
| or modules. | ||
|
|
||
| Note that although a "keyboard size" module has pads on the left and right |
There was a problem hiding this comment.
What do you mean? It does not have pads on both sides.
It may look like the pad could be on the either side from a mechanical point of view when looking at the keyboard. But nothing about the system is designed to handle that (neither firmware, mechanical or electrical).
There also isn't an easy way you could mod the keyboard to have the pads on the other side, so I don't think it's accurate to say there are pads on both sides.
Maybe we could add that note to the mechanical documentation? The only case where you need to know about this, is when you want to build your own module.
But really on the other side of the module there isn't enough space to put a microcontroller and pads 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested the firmware logic and found that it does not handle the
two possible pads for the keyboard symmetrically. This patch updates
the spec, but another option would be to patch the EC firmware to
recognize keyboard-sized modules with their primary connection on
the right hand side.