[Fix] Fixed console semantic syntax highlighting and top level autocompletion in the global env#17
Conversation
- Resolve console syntax colors from the active VS Code theme, including auto-detected preferred themes - Use VS Code extension contributions for theme lookup instead of hard-coded extension paths - Update console language server workspace access for current languageserver internals - Avoid stale token colors after autocomplete edits
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3d0827100
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const response = await this.postToSessionServer({ type: "workspace" }); | ||
| if (!this.isWorkspaceData(response)) { | ||
| return; |
There was a problem hiding this comment.
This replaces the watched workspace.json read with a POST for {type:"workspace"}, but the vscode-R session server is optional and its web server handles member-completion requests rather than workspace snapshots. In sessions where request.server is null/absent or the server returns null for this request, updateWorkspace() now returns without reading the workspace.json file that workspace.lock is watching, so workspaceData remains undefined and global-environment completions/search-path sync stop working. Please keep the file-based workspace.json path as the source or at least as a fallback.
Useful? React with 👍 / 👎.
1 participant
Summary
Fixed live R session completions for global objects
Fixed console semantic syntax highlighting to use the active VS Code theme, including auto-detected preferred themes.
Removed hard-coded theme extension path discovery and now relies on VS Code’s extension contribution registry.
Updated the console R language-server helper to use self$get_workspace(...) instead of stale self$workspace access.
Updated changelog and bumped package version to 0.2.8.