Skip to content

Fixed completion search for packages with large list of members#18

Merged
Fred-Wu merged 2 commits into
mainfrom
query-completion
Jun 19, 2026
Merged

Fixed completion search for packages with large list of members#18
Fred-Wu merged 2 commits into
mainfrom
query-completion

Conversation

@Fred-Wu

@Fred-Wu Fred-Wu commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Fix completion search for packages with large member lists.

Previously, triggering completion at pkg:: showed only the initial static list returned by languageserver. For large packages, members outside that initial list could not be found by typing in the Quick Pick window; they only appeared after typing a prefix in the console first, such as pkg::p.

This changes package member completion to use a package-only createQuickPick() path that refreshes pkg:: / pkg::: results while typing.

@Fred-Wu Fred-Wu marked this pull request as ready for review June 19, 2026 02:07
@Fred-Wu Fred-Wu merged commit 7a9fcbf into main Jun 19, 2026
12 checks passed
@Fred-Wu Fred-Wu deleted the query-completion branch June 19, 2026 02:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4d3167424

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md

All notable changes to R Console will be documented in this file.

## [0.2.9] - 2026-06-19

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align the release entry with package metadata

This new dated 0.2.9 section makes this look ready to tag as v0.2.9, but package.json and package-lock.json still declare 0.2.8; I checked .github/workflows/release.yml and the publish jobs explicitly fail when GITHUB_REF_NAME is not v + package.version. Tagging this commit as v0.2.9 would therefore build 0.2.8 VSIX artifacts and then fail before publishing, so either bump the package metadata in the same release change or keep this under an unreleased section.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant