Annotate return_overflow in mod_write() (CID #1604620)
#5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is arguably another example of trying to return a value not representable in the function return type. It's highly unlikely that anyone will pass a buffer of more than SSIZE_MAX bytes, but Coverity apparently doesn't consider that. CIDs #1604605 and #1604616 explicitly do return error values not representable as int, but a ridiculously large buffer allocation will fail long before anyone calls mod_write(), so we annotate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is arguably another example of trying to return a value not representable in the function return type. It's highly unlikely that anyone will pass a buffer of more than
SSIZE_MAXbytes, but Coverity apparently doesn't consider that.CIDs #1604605 and #1604616 explicitly do return error values not representable as int, but a ridiculously large buffer allocation will fail long before anyone calls
mod_write(), so we annotate.