Switch Coverity-only code to assert (CID #1619299) #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fr_nbo_from_uint64v() does not have an error return--it doesn't need one. The buffers are big enough, the "| 0x80" means it will always use as least one byte, so fr_high_bit_pos() won't return 0 even if num == 0. So adding a bogus error return check for Coverity actually misleads Coverity about any call to fr_nbo_from_uint64v(), making it the probable cause of the CID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fr_nbo_from_uint64v()does not have an error return--it doesn't need one. The buffers are big enough, the| 0x80means it will always use as least one byte, sofr_high_bit_pos()won't return0even ifnum == 0. So adding a bogus error return check for Coverity actually misleads Coverity about any call tofr_nbo_from_uint64v(), making it the probable cause of the CID.