Skip to content

Remove unnecessary new Promise call in ProcessLocalesPlugin #8310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
+2 −6
Open

Remove unnecessary new Promise call in ProcessLocalesPlugin #8310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions _scripts/ProcessLocalesPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ class ProcessLocalesPlugin {
}

for (let [locale, data] of this.locales) {
// eslint-disable-next-line no-async-promise-executor
promises.push(new Promise(async (resolve) => {
promises.push(async () => {
if (IS_DEV_SERVER && compiler.fileTimestamps) {
const filePath = join(this.inputDir, `${locale}.yaml`)

Expand All @@ -86,7 +85,6 @@ class ProcessLocalesPlugin {
} else {
const { filename, source } = this.cache.get(locale)
compilation.emitAsset(filename, source, { minimized: true })
resolve()
return
}
}
Expand Down Expand Up @@ -117,9 +115,7 @@ class ProcessLocalesPlugin {
}

compilation.emitAsset(filename, source, { minimized: true })

resolve()
}))
})
}

await Promise.all(promises)
Expand Down