Introduce 4.0 compatibility #68
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmetayer
reviewed
Nov 30, 2020
Contributor
mmetayer
left a comment
mmetayer
left a comment
There was a problem hiding this comment.
Good start! Some comments:
- you'd better use
git moveto move files, it would be easier to track which files were simply moved and which ones were actually created/deleted - please remove all commented
usestatements, it will improve readability - please do not commit permission changes, the file permissions should be
644, except for executable ones - And more importantly, please update the tests 🙂
| const TEXT_COLLECTION = 'pim_catalog_text_collection'; | ||
|
|
||
| const BACKEND_TYPE_TEXT_COLLECTION = 'textCollection'; | ||
| const BACKEND_TYPE_TEXT_COLLECTION = 'text_collection'; |
Contributor
There was a problem hiding this comment.
Why did you change the backend type?
Comment on lines
+72
to
+73
| 'wildcard' => [ | ||
| $attributePath => '*' . $value . '*', |
Contributor
There was a problem hiding this comment.
I'm not sure a wildcard query will work with an array field
| { | ||
| public function createWithoutCheckingData(Attribute $attribute, ?string $channelCode, ?string $localeCode, $data): ValueInterface | ||
| { | ||
| sort($data); |
Contributor
There was a problem hiding this comment.
why do you want to sort the data here?
Contributor
|
I'll try to answer your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I would like to revive this extension, this PR introduces compatibility with Akeneo 4.0.
This PR is intentionally a draft as there are a few todos that require feedback and in general, I would like to know if I am on the right track.
In the current state, the extension is installable, a new attribute of type "Text Collection" can be created and used. Interaction with the attribute is working (adding/deleting/sorting) and changes are persisted.
Open todos:
valueskey is empty.pim_extended_attribute_type.denormalizer.flat.text_collectionclass still needed?